Skip to content

Commit 13b6369

Browse files
committed
fixup
1 parent f6167f8 commit 13b6369

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

src/Servers/Kestrel/Core/test/HeartbeatTests.cs

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
33

44
using System;
5+
using System.Globalization;
56
using System.Linq;
67
using System.Threading;
78
using System.Threading.Tasks;
@@ -22,7 +23,7 @@ public void HeartbeatIntervalIsOneSecond()
2223
}
2324

2425
[Fact]
25-
public async Task HeartbeatTakingLongerThanIntervalIsLoggedAsError()
26+
public async Task HeartbeatTakingLongerThanIntervalIsLoggedAsWarning()
2627
{
2728
var systemClock = new MockSystemClock();
2829
var heartbeatHandler = new Mock<IHeartbeatHandler>();
@@ -57,11 +58,16 @@ public async Task HeartbeatTakingLongerThanIntervalIsLoggedAsError()
5758
await blockedHeartbeatTask.DefaultTimeout();
5859

5960
heartbeatHandler.Verify(h => h.OnHeartbeat(now), Times.Once());
60-
Assert.Equal($"As of\"{now}\", the heartbeat has been running for \"{heartbeatDuration}\" which is longer than \"{Heartbeat.Interval}\". This could be caused by thread pool starvation.", kestrelTrace.Logger.Messages.Single(message => message.LogLevel == LogLevel.Warning).Message);
61+
62+
var warningMessage = kestrelTrace.Logger.Messages.Single(message => message.LogLevel == LogLevel.Warning).Message;
63+
Assert.Equal($"As of \"{now.ToString(CultureInfo.InvariantCulture)}\", the heartbeat has been running for "
64+
+ $"\"{heartbeatDuration.ToString("c", CultureInfo.InvariantCulture)}\" which is longer than "
65+
+ $"\"{Heartbeat.Interval.ToString("c", CultureInfo.InvariantCulture)}\". "
66+
+ "This could be caused by thread pool starvation.", warningMessage);
6167
}
6268

6369
[Fact]
64-
public async Task HeartbeatTakingLongerThanIntervalIsNotLoggedAsErrorIfDebuggerAttached()
70+
public async Task HeartbeatTakingLongerThanIntervalIsNotLoggedIfDebuggerAttached()
6571
{
6672
var systemClock = new MockSystemClock();
6773
var heartbeatHandler = new Mock<IHeartbeatHandler>();

0 commit comments

Comments
 (0)