Skip to content

Commit 11dec60

Browse files
richlanderwtgodbe
andauthored
Update helix references (#61755)
* Update helix references * Update VM queues to AL3 * Revert Ubuntu change * Update eng/targets/Helix.Common.props Co-authored-by: William Godbe <[email protected]> * Update registry URL --------- Co-authored-by: William Godbe <[email protected]>
1 parent bc40d8b commit 11dec60

File tree

6 files changed

+27
-26
lines changed

6 files changed

+27
-26
lines changed

.azure/pipelines/ci.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -669,14 +669,13 @@ extends:
669669
path: artifacts/log/
670670
publishOnError: true
671671
includeForks: true
672-
673672
# Source build
674673
- template: /eng/common/templates-official/job/source-build.yml@self
675674
parameters:
676675
enableInternalSources: true
677676
platform:
678677
name: 'Managed'
679-
container: 'mcr.microsoft.com/dotnet-buildtools/prereqs:centos-stream9'
678+
container: 'mcr.microsoft.com/dotnet-buildtools/prereqs:centos-stream-10-amd64'
680679
buildScript: './eng/build.sh'
681680
buildArguments: '--source-build $(_InternalRuntimeDownloadArgs)'
682681
jobProperties:

eng/targets/Helix.Common.props

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
<Project>
22
<!-- This file is shared between Helix.proj and .csproj files. -->
33
<PropertyGroup>
4-
<HelixQueueAlmaLinux8>(AlmaLinux.8.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:almalinux-8-helix-amd64</HelixQueueAlmaLinux8>
5-
<HelixQueueAlpine318>(Alpine.318.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:alpine-3.18-helix-amd64</HelixQueueAlpine318>
6-
<HelixQueueDebian12>(Debian.12.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:debian-12-helix-amd64</HelixQueueDebian12>
7-
<HelixQueueFedora41>(Fedora.41.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:fedora-41-helix</HelixQueueFedora41>
8-
<HelixQueueMariner>(Mariner)[email protected]/dotnet-buildtools/prereqs:cbl-mariner-2.0-helix-amd64</HelixQueueMariner>
9-
<HelixQueueArmDebian12>(Debian.12.Arm64.Open)[email protected]/dotnet-buildtools/prereqs:debian-12-helix-arm64v8</HelixQueueArmDebian12>
4+
<HelixQueueAlmaLinux>(AlmaLinux.9.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:almalinux-9-helix-amd64</HelixQueueAlmaLinux>
5+
<HelixQueueAlpine>(Alpine.321.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:alpine-3.21-helix-amd64</HelixQueueAlpine>
6+
<HelixQueueAzureLinux>(AzureLinux.30.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:azurelinux-3.0-helix-amd64</HelixQueueAzureLinux>
7+
<HelixQueueDebian>(Debian.13.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:debian-13-helix-amd64</HelixQueueDebian>
8+
<HelixQueueFedora>(Fedora.42.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:fedora-42-helix-amd64</HelixQueueFedora>
9+
<!-- Arm64 -->
10+
<HelixQueueArmDebian>(Debian.13.Arm64.Open)[email protected]/dotnet-buildtools/prereqs:debian-13-helix-arm64v8</HelixQueueArmDebian>
1011

1112
<!-- Do not attempt to override global property. -->
1213
<RunQuarantinedTests Condition=" '$(RunQuarantinedTests)' == '' ">false</RunQuarantinedTests>
@@ -38,14 +39,15 @@
3839
<!-- aspnetcore-quarantined-tests (quarantined-tests.yml) and RunHelix.ps1 -RunQuarantinedTests -->
3940
<ItemGroup>
4041
<!-- Linux -->
41-
<HelixAvailableTargetQueue Include="$(HelixQueueAlmaLinux8)" Platform="Linux" />
42+
<HelixAvailableTargetQueue Include="$(HelixQueueAlmaLinux)" Platform="Linux" />
4243

4344
<!-- Containers -->
44-
<HelixAvailableTargetQueue Include="$(HelixQueueAlpine318)" Platform="Linux" />
45-
<HelixAvailableTargetQueue Include="$(HelixQueueDebian12)" Platform="Linux" />
46-
<HelixAvailableTargetQueue Include="$(HelixQueueFedora41)" Platform="Linux" />
47-
<HelixAvailableTargetQueue Include="$(HelixQueueMariner)" Platform="Linux" />
48-
<HelixAvailableTargetQueue Include="$(HelixQueueArmDebian12)" Platform="Linux" />
45+
<HelixAvailableTargetQueue Include="$(HelixQueueAlpine)" Platform="Linux" />
46+
<HelixAvailableTargetQueue Include="$(HelixQueueAzureLinux)" Platform="Linux" />
47+
<HelixAvailableTargetQueue Include="$(HelixQueueDebian)" Platform="Linux" />
48+
<HelixAvailableTargetQueue Include="$(HelixQueueFedora)" Platform="Linux" />
49+
<!-- Arm64 -->
50+
<HelixAvailableTargetQueue Include="$(HelixQueueArmDebian)" Platform="Linux" />
4951

5052
<!-- Mac -->
5153
<HelixAvailableTargetQueue Include="OSX.15.Amd64.Open" Platform="OSX" />

eng/targets/Helix.targets

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@
1616

1717
<PropertyGroup Condition="'$(TestDependsOnPlaywright)' == 'true'">
1818
<SkipHelixQueues>
19-
$(HelixQueueAlmaLinux8);
20-
$(HelixQueueAlpine318);
21-
$(HelixQueueDebian12);
19+
$(HelixQueueAlmaLinux);
20+
$(HelixQueueAlpine);
21+
$(HelixQueueAzureLinux);
22+
$(HelixQueueDebian);
2223
$(HelixQueueFedora40);
23-
$(HelixQueueMariner);
2424
Ubuntu.2004.Amd64.Open;
2525
</SkipHelixQueues>
2626
<SkipHelixArm>true</SkipHelixArm>

src/ProjectTemplates/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ An entire test project can be configured to skip specific platforms using the `<
9797

9898
```xml
9999
<SkipHelixQueues>
100-
$(HelixQueueArmDebian12);
100+
$(HelixQueueArmDebian);
101101
</SkipHelixQueues>
102102
```
103103

@@ -109,7 +109,7 @@ When tests are run as part of the CI infrastructure, a number of different timeo
109109

110110
##### Helix job timeout
111111

112-
When queuing test jobs to the Helix infrastructure, a timeout value is passed that the entire Helix job must complete within, i.e. that job running on a single queue. This default value is set in [eng\targets\Helix.props](/eng/targets/Helix.props):
112+
When queuing test jobs to the Helix infrastructure, a timeout value is passed that the entire Helix job must complete within, i.e. that job running on a single queue. This default value is set in [eng\targets\Helix.props](/eng/targets/Helix.props):
113113

114114
```xml
115115
<HelixTimeout>00:45:00</HelixTimeout>

src/ProjectTemplates/test/Templates.Mvc.Tests/Templates.Mvc.Tests.csproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@
2727
<!-- These tests fail in Helix in Debian and Mariner due to error -901 -->
2828
<!-- Disabling on those OSes until a better fix can be identified -->
2929
<SkipHelixQueues>
30-
$(HelixQueueArmDebian12);
31-
$(HelixQueueDebian12);
32-
$(HelixQueueMariner);
30+
$(HelixQueueArmDebian);
31+
$(HelixQueueAzureLinux);
32+
$(HelixQueueDebian);
3333
$(SkipHelixQueues)
3434
</SkipHelixQueues>
3535
</PropertyGroup>

src/Testing/src/xunit/HelixConstants.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ namespace Microsoft.AspNetCore.InternalTesting;
66
public static class HelixConstants
77
{
88
public const string Windows10Arm64 = "Windows.10.Arm64v8.Open;";
9-
public const string DebianAmd64 = "Debian.11.Amd64.Open;";
10-
public const string DebianArm64 = "Debian.11.Arm64.Open;";
11-
public const string AlmaLinuxAmd64 = "(AlmaLinux.8.Amd64.Open)Ubuntu.1804[email protected]/dotnet-buildtools/prereqs:almalinux-8-helix-amd64;";
9+
public const string DebianAmd64 = "Debian.13.Amd64.Open;";
10+
public const string DebianArm64 = "Debian.13.Arm64.Open;";
11+
public const string AlmaLinuxAmd64 = "(AlmaLinux.9.Amd64.Open)azurelinux.3[email protected]/dotnet-buildtools/prereqs:almalinux-9-helix-amd64;";
1212
public const string NativeAotNotSupportedHelixQueues = "All.OSX;All.Linux;Windows.11.Amd64.Client.Open;Windows.11.Amd64.Client;Windows.Amd64.Server2022.Open;Windows.Amd64.Server2022;windows.11.arm64.open;windows.11.arm64";
1313
}

0 commit comments

Comments
 (0)