[Mono.Android] Commit api-34.xml instead of generating it on every build.

Author: jpobst

Documentation/workflow/HowToAddNewApiLevel.md

@@ -23,9 +23,16 @@ the new platform will be downloaded to your local Android SDK.
   - *or* run manually: `param-name-importer.exe -source-stub-zip C:/Users/USERNAME/android-toolchain/sdk/platforms/android-S/android-stubs-src.jar -output-text api-S.params.txt -output-xml api-S.params.xml -verbose -framework-only`
 - Copy the produced `api-X.params.txt` file to `/src/Mono.Android/Profiles/`
 
-### Other Infrastructure Changes
+### Generate `api.xml` File
 
+- Run `xaprepare android-sdk-platforms=all` to download all Android SDK platforms
 - Add level to `/build-tools/api-merge/merge-configuration.xml` to create `api-S.xml.class-parse`
+- Run the following command to create a merged `api.xml`:
+  - `dotnet-local.cmd build build-tools\create-android-api -t:_GenerateApiDescription`
+- Copy the `bin\BuildDebug\api\api-xx.xml` file to `src\Mono.Android\Profiles`
+
+### Other Infrastructure Changes
+
 - Add level to `/build-tools/Xamarin.Android.Tools.BootstrapTasks/Xamarin.Android.Tools.BootstrapTasks/CheckApiCompatibility.cs`
   to enable running ApiCompat against the new level. (ex: `{ "v11.0.99", "v11.0" }`)
 - Add level to `/build-tools/api-xml-adjuster/Makefile`

build-tools/automation/azure-pipelines.yaml

@@ -342,7 +342,7 @@ stages:
         installLegacyDotNet: false
         restoreNUnitConsole: false
         updateMono: false
-        androidSdkPlatforms: 23,24,25,26,27,28,29,30,31,32,33,$(DefaultTestSdkPlatforms)
+        androidSdkPlatforms: $(DefaultTestSdkPlatforms)
 
     - task: NuGetAuthenticate@1
       displayName: authenticate with azure artifacts

build-tools/create-android-api/create-android-api.csproj

@@ -98,7 +98,6 @@
 
   <!-- Merges various 'api-X.xml.in' files into single 'api.xml' file -->
   <Target Name="_GenerateApiDescription"
-      BeforeTargets="Build"
       DependsOnTargets="_AdjustApiXml"
       Inputs="@(ApiFileDefinition->'%(ApiAdjustedXml)')"
       Outputs="@(_MergedXmlFiles->'%(MergedXml)')">

build-tools/xaprepare/xaprepare/Application/AndroidToolchainComponent.cs

@@ -45,11 +45,15 @@ public void AddToInventory ()
 	class AndroidPlatformComponent : AndroidToolchainComponent
 	{
 		public string ApiLevel { get; }
+		public bool IsLatestStable { get; }
+		public bool IsPreview { get; }
 
-		public AndroidPlatformComponent (string name, string apiLevel, string pkgRevision)
-			: base (name, Path.Combine ("platforms", $"android-{apiLevel}"), pkgRevision: pkgRevision, buildToolName: $"android-sdk-{name}", buildToolVersion:$"{apiLevel}.{pkgRevision}")
+		public AndroidPlatformComponent (string name, string apiLevel, string pkgRevision, bool isLatestStable = false, bool isPreview = false)
+			: base (name, Path.Combine ("platforms", $"android-{apiLevel}"), pkgRevision: pkgRevision, buildToolName: $"android-sdk-{name}", buildToolVersion: $"{apiLevel}.{pkgRevision}")
 		{
 			ApiLevel = apiLevel;
+			IsLatestStable = isLatestStable;
+			IsPreview = isPreview;
 		}
 	}
 

build-tools/xaprepare/xaprepare/ConfigAndData/Dependencies/AndroidToolchain.cs

@@ -70,7 +70,7 @@ public AndroidToolchain ()
 				new AndroidPlatformComponent ("platform-31_r01",   apiLevel: "31", pkgRevision: "1"),
 				new AndroidPlatformComponent ("platform-32_r01",   apiLevel: "32", pkgRevision: "1"),
 				new AndroidPlatformComponent ("platform-33-ext3_r03",   apiLevel: "33", pkgRevision: "3"),
-				new AndroidPlatformComponent ("platform-34-ext7_r02",   apiLevel: "34", pkgRevision: "2"),
+				new AndroidPlatformComponent ("platform-34-ext7_r02",   apiLevel: "34", pkgRevision: "2", isLatestStable: true),
 
 				new AndroidToolchainComponent ("sources-34_r01",
 					destDir: Path.Combine ("sources", "android-34"),

build-tools/xaprepare/xaprepare/Main.cs

@@ -30,7 +30,7 @@ sealed class ParsedOptions
 			public bool IgnoreMaxMonoVersion   { get; set; }
 			public bool IgnoreMinMonoVersion   { get; set; }
 			public RefreshableComponent RefreshList { get; set; }
-			public IEnumerable<string> AndroidSdkPlatforms { get; set; } = Enumerable.Empty<string> ();
+			public IEnumerable<string> AndroidSdkPlatforms { get; set; } = new [] { "latest" };
 		}
 
 		public static int Main (string[] args)
@@ -105,7 +105,7 @@ static async Task<int> Run (string[] args)
 				{"auto-provision-uses-sudo=", $"Allow use of sudo(1) when provisioning", v => parsedOptions.AutoProvisionUsesSudo = ParseBoolean (v)},
 				{"ignore-max-mono-version=", $"Ignore the maximum supported Mono version restriction", v => parsedOptions.IgnoreMaxMonoVersion = ParseBoolean (v)},
 				{"ignore-min-mono-version=", $"Ignore the minimum supported Mono version restriction", v => parsedOptions.IgnoreMinMonoVersion = ParseBoolean (v)},
-				{"android-sdk-platforms=", "Comma separated list of Android SDK platform levels to be installed. Defaults to all if no value is provided.", v => parsedOptions.AndroidSdkPlatforms = ParseAndroidSdkPlatformLevels (v?.Trim () ?? String.Empty) },
+				{"android-sdk-platforms=", "Comma separated list of Android SDK platform levels to be installed or 'latest' or 'all'. Defaults to 'latest' if no value is provided.", v => parsedOptions.AndroidSdkPlatforms = ParseAndroidSdkPlatformLevels (v?.Trim () ?? String.Empty) },
 				"",
 				{"h|help", "Show this help message", v => parsedOptions.ShowHelp = true },
 			};
@@ -333,6 +333,15 @@ RefreshableComponent ParseSingleComponent (string component) {
 
 		static IEnumerable<string> ParseAndroidSdkPlatformLevels (string list)
 		{
+			// If the user specified "all" we return 'all' to indicate that all platforms should be installed.
+			if (string.Compare ("all", list, StringComparison.OrdinalIgnoreCase) == 0)
+				return new string [] { "all" };
+
+			// If the user did not specify anything, we return "latest" to indicate that only the latest platform should be installed.
+			if (string.IsNullOrEmpty (list) || string.Compare ("latest", list, StringComparison.OrdinalIgnoreCase) == 0)
+				return new string [] { "latest" };
+
+			// The user specified a list of platform levels to install, so we should respect that.
 			return list.Split (',').Select (item => item.Trim ());
 		}
 	}

build-tools/xaprepare/xaprepare/Steps/Step_Android_SDK_NDK.cs

@@ -254,11 +254,9 @@ void Check (Context context, string packageCacheDir, string sdkRoot, AndroidTool
 			}
 
 			// If only specific Android SDK platforms were requested, ignore ones that were not requested
-			if (component is AndroidPlatformComponent apc && context.AndroidSdkPlatforms.Any ()) {
-				if (!context.AndroidSdkPlatforms.Contains (apc.ApiLevel)) {
-					LogStatus ($"skipping, not requested", padLeft, Log.InfoColor);
-					return;
-				}
+			if (component is AndroidPlatformComponent apc && !ShouldInstall (apc, context)) {
+				LogStatus ($"skipping, not requested", padLeft, Log.InfoColor);
+				return;
 			}
 
 			if (missing)
@@ -278,6 +276,22 @@ void Check (Context context, string packageCacheDir, string sdkRoot, AndroidTool
 			toInstall.Add (pkg);
 		}
 
+		bool ShouldInstall (AndroidPlatformComponent component, Context context)
+		{
+			var platforms = context.AndroidSdkPlatforms;
+
+			// If no specific platforms were requested, install everything
+			if (!platforms.Any () || platforms.Contains ("all"))
+				return true;
+
+			// If "latest" was requested, install the highest available stable version and any preview versions
+			if (platforms.Contains ("latest") && (component.IsLatestStable || component.IsPreview))
+				return true;
+
+			// Check if this is a user-requested platform
+			return context.AndroidSdkPlatforms.Contains (component.ApiLevel);
+		}
+
 		bool IsInstalled (AndroidToolchainComponent component, string path, out bool missing)
 		{
 			missing = true;

src/Mono.Android/Mono.Android.targets

@@ -18,7 +18,7 @@
   </ItemGroup>
 
   <PropertyGroup>
-    <_ApiXmlLocation>..\..\bin\Build$(Configuration)\api\</_ApiXmlLocation>
+    <_ApiXmlLocation>Profiles\</_ApiXmlLocation>
   </PropertyGroup>
 
   <!-- Creates 'AssemblyInfo.cs' with appropriate version information -->