consolidate builder for sqlauthparameters and use serverSpn as resource

Author: twsouthwick

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlInternalConnectionTds.cs

@@ -2435,13 +2435,10 @@ internal SqlFedAuthToken GetFedAuthToken(SqlFedAuthInfo fedAuthInfo)
                 try
                 {
                     var authParamsBuilder = new SqlAuthenticationParameters.Builder(
-                            authenticationMethod: ConnectionOptions.Authentication,
-                            resource: fedAuthInfo.spn,
-                            authority: fedAuthInfo.stsurl,
-                            serverName: ConnectionOptions.DataSource,
-                            databaseName: ConnectionOptions.InitialCatalog)
-                        .WithConnectionId(_clientConnectionId)
-                        .WithConnectionTimeout(ConnectionOptions.ConnectTimeout);
+                        connection: this,
+                        resource: fedAuthInfo.spn,
+                        authority: fedAuthInfo.stsurl);
+
                     switch (ConnectionOptions.Authentication)
                     {
                         case SqlAuthenticationMethod.ActiveDirectoryIntegrated:

src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlInternalConnectionTds.cs

@@ -4,7 +4,6 @@
 
 using System;
 using System.Collections.Generic;
-using System.Data;
 using System.Data.Common;
 using System.Diagnostics;
 using System.Diagnostics.CodeAnalysis;
@@ -15,11 +14,11 @@
 using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
+using System.Transactions;
 using Microsoft.Data.Common;
 using Microsoft.Data.ProviderBase;
 using Microsoft.Data.SqlClient.ConnectionPool;
 using Microsoft.Identity.Client;
-using System.Transactions;
 
 
 namespace Microsoft.Data.SqlClient
@@ -137,7 +136,7 @@ sealed internal class SqlInternalConnectionTds : SqlInternalConnection, IDisposa
         // The Federated Authentication returned by TryGetFedAuthTokenLocked or GetFedAuthToken.
         SqlFedAuthToken _fedAuthToken = null;
         internal byte[] _accessTokenInBytes;
-        internal readonly Func<SqlAuthenticationParameters, CancellationToken,Task<SqlAuthenticationToken>> _accessTokenCallback;
+        internal readonly Func<SqlAuthenticationParameters, CancellationToken, Task<SqlAuthenticationToken>> _accessTokenCallback;
 
         private readonly ActiveDirectoryAuthenticationTimeoutRetryHelper _activeDirectoryAuthTimeoutRetryHelper;
 
@@ -1651,12 +1650,12 @@ private void OpenLoginEnlist(TimeoutTimer timeout, SqlConnectionString connectio
                 else
                 {
                     _timeoutErrorInternal.SetFailoverScenario(false); // not a failover scenario
-                    LoginNoFailover(dataSource, 
-                            newPassword, 
-                            newSecurePassword, 
+                    LoginNoFailover(dataSource,
+                            newPassword,
+                            newSecurePassword,
                             redirectedUserInstance,
-                            connectionOptions, 
-                            credential, 
+                            connectionOptions,
+                            credential,
                             timeout);
                 }
 
@@ -2625,7 +2624,7 @@ internal void OnFedAuthInfo(SqlFedAuthInfo fedAuthInfo)
 
                     if (_newDbConnectionPoolAuthenticationContext != null)
                     {
-                         _dbConnectionPool.AuthenticationContexts.TryAdd(_dbConnectionPoolAuthenticationContextKey, _newDbConnectionPoolAuthenticationContext);
+                        _dbConnectionPool.AuthenticationContexts.TryAdd(_dbConnectionPoolAuthenticationContextKey, _newDbConnectionPoolAuthenticationContext);
                     }
                 }
             }
@@ -2739,13 +2738,10 @@ internal SqlFedAuthToken GetFedAuthToken(SqlFedAuthInfo fedAuthInfo)
                 try
                 {
                     var authParamsBuilder = new SqlAuthenticationParameters.Builder(
-                        authenticationMethod: ConnectionOptions.Authentication,
+                        connection: this,
                         resource: fedAuthInfo.spn,
-                        authority: fedAuthInfo.stsurl,
-                        serverName: ConnectionOptions.DataSource,
-                        databaseName: ConnectionOptions.InitialCatalog)
-                        .WithConnectionId(_clientConnectionId)
-                        .WithConnectionTimeout(ConnectionOptions.ConnectTimeout);
+                        authority: fedAuthInfo.stsurl);
+
                     switch (ConnectionOptions.Authentication)
                     {
                         case SqlAuthenticationMethod.ActiveDirectoryIntegrated:

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SSPI/SSPIContextProvider.cs

@@ -75,11 +75,10 @@ private bool RunGenerateSspiClientContext(ReadOnlySpan<byte> incomingBlob, IBuff
         private static SqlAuthenticationParameters CreateSqlAuthParams(SqlInternalConnectionTds connection, string serverSpn)
         {
             var auth = new SqlAuthenticationParameters.Builder(
-                authenticationMethod: connection.ConnectionOptions.Authentication,
-                resource: null,
-                authority: null,
-                serverName: serverSpn,
-                connection.ConnectionOptions.InitialCatalog);
+                connection: connection,
+                resource: serverSpn,
+                authority: null);
+
 
             if (connection.ConnectionOptions.UserID is { } userId)
             {

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlAuthenticationParameters.cs

@@ -49,7 +49,7 @@ protected SqlAuthenticationParameters(
             string authority,
             string userId,
             string password,
-            Guid connectionId, 
+            Guid connectionId,
             int connectionTimeout)
         {
             AuthenticationMethod = authenticationMethod;
@@ -149,11 +149,13 @@ public Builder WithConnectionTimeout(int timeout)
                 return this;
             }
 
-            internal Builder(SqlAuthenticationMethod authenticationMethod, string resource, string authority, string serverName, string databaseName)
+            internal Builder(SqlInternalConnectionTds connection, string resource, string authority)
             {
-                _authenticationMethod = authenticationMethod;
-                _serverName = serverName;
-                _databaseName = databaseName;
+                _authenticationMethod = connection.ConnectionOptions.Authentication;
+                _serverName = connection.ConnectionOptions.DataSource;
+                _databaseName = connection.ConnectionOptions.InitialCatalog;
+                _connectionTimeout = connection.ConnectionOptions.ConnectTimeout;
+                _connectionId = connection.ClientConnectionId;
                 _resource = resource;
                 _authority = authority;
             }