Remove CER (#3535)

* Remove CER from sqlbulkcopy

* Remove CER from SqlDataReader

* Remove CER from SqlDependency?

* Remove CER From WaitHandleDbConnectionPool

* Remove CER from SqlTransaction

* Remove CER from SqlUtil

* Remove CER from SniNativeWrapper

* Remove CER from netcore SqlCommand

* Remove CER from SqlConnection (netcore) and SqlCommandBuilder

* Remove CER from SqlDelegatedTransaction

* Remove CER from SqlInternalConnection

* Remove CER from SqlInternalConnectionTds

* Remove CER from TdsParser (netcore)

* Remove CER from TdsParserStateObject (netcore)

* Remove CER from TdsParserStateObjectNative and LocalDbApi

* Remove CER from SqlCommand

* Remove CER from SqlConnection

* Remove CER from SqlInternalConnectionTds.cs and SqlDependencyListener.cs

* Cleanup the rest of CER

* Removing the last batches of CER exception stuff

* Add comments that indicate where CER exception handling was removed

Author: benrr101

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlCommand.cs

@@ -1411,18 +1411,7 @@ private void BeginExecuteNonQueryInternalReadStage(TaskCompletionSource<object>
                 CachedAsyncState.SetActiveConnectionAndResult(completion, nameof(EndExecuteNonQuery), _activeConnection);
                 _stateObj.ReadSni(completion);
             }
-            // Cause of a possible unstable runtime situation on facing with `OutOfMemoryException` and `StackOverflowException` exceptions,
-            // trying to call further functions in the catch of either may fail that should be considered on debuging!
-            catch (System.OutOfMemoryException e)
-            {
-                _activeConnection.Abort(e);
-                throw;
-            }
-            catch (System.StackOverflowException e)
-            {
-                _activeConnection.Abort(e);
-                throw;
-            }
+            // @TODO: CER Exception Handling was removed here (see GH#3581)
             catch (Exception)
             {
                 // Similarly, if an exception occurs put the stateObj back into the pool.
@@ -1968,20 +1957,7 @@ private void BeginExecuteXmlReaderInternalReadStage(TaskCompletionSource<object>
                 CachedAsyncState.SetActiveConnectionAndResult(completion, nameof(EndExecuteXmlReader), _activeConnection);
                 _stateObj.ReadSni(completion);
             }
-            // Cause of a possible unstable runtime situation on facing with `OutOfMemoryException` and `StackOverflowException` exceptions,
-            // trying to call further functions in the catch of either may fail that should be considered on debuging!
-            catch (System.OutOfMemoryException e)
-            {
-                _activeConnection.Abort(e);
-                completion.TrySetException(e);
-                throw;
-            }
-            catch (System.StackOverflowException e)
-            {
-                _activeConnection.Abort(e);
-                completion.TrySetException(e);
-                throw;
-            }
+            // @TODO: CER Exception Handling was removed here (see GH#3581)
             catch (Exception e)
             {
                 // Similarly, if an exception occurs put the stateObj back into the pool.
@@ -2633,20 +2609,7 @@ private void BeginExecuteReaderInternalReadStage(TaskCompletionSource<object> co
                 CachedAsyncState.SetActiveConnectionAndResult(completion, nameof(EndExecuteReader), _activeConnection);
                 _stateObj.ReadSni(completion);
             }
-            // Cause of a possible unstable runtime situation on facing with `OutOfMemoryException` and `StackOverflowException` exceptions,
-            // trying to call further functions in the catch of either may fail that should be considered on debuging!
-            catch (System.OutOfMemoryException e)
-            {
-                _activeConnection.Abort(e);
-                completion.TrySetException(e);
-                throw;
-            }
-            catch (System.StackOverflowException e)
-            {
-                _activeConnection.Abort(e);
-                completion.TrySetException(e);
-                throw;
-            }
+            // @TODO: CER Exception Handling was removed here (see GH#3581)
             catch (Exception e)
             {
                 // Similarly, if an exception occurs put the stateObj back into the pool.
@@ -4114,9 +4077,7 @@ private SqlDataReader GetParameterEncryptionDataReader(out Task returnTask, Task
                     SqlCommand command = (SqlCommand)state;
                     bool processFinallyBlockAsync = true;
                     bool decrementAsyncCountInFinallyBlockAsync = true;
-#if NETFRAMEWORK 
-                    RuntimeHelpers.PrepareConstrainedRegions();
-#endif
+
                     try
                     {
                         // Check for any exceptions on network write, before reading.
@@ -4187,10 +4148,7 @@ private SqlDataReader GetParameterEncryptionDataReaderAsync(out Task returnTask,
             {
                 bool processFinallyBlockAsync = true;
                 bool decrementAsyncCountInFinallyBlockAsync = true;
-
-#if NETFRAMEWORK
-                RuntimeHelpers.PrepareConstrainedRegions();
-#endif
+                
                 try
                 {
                     // Check for any exceptions on network write, before reading.

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlConnection.cs

@@ -1237,35 +1237,13 @@ public override void ChangeDatabase(string database)
             SqlStatistics statistics = null;
             RepairInnerConnection();
             SqlClientEventSource.Log.TryCorrelationTraceEvent("SqlConnection.ChangeDatabase | API | Correlation | Object Id {0}, Activity Id {1}, Database {2}", ObjectID, ActivityCorrelator.Current, database);
-            TdsParser bestEffortCleanupTarget = null;
-
-#if NETFRAMEWORK
-            RuntimeHelpers.PrepareConstrainedRegions();
-#endif
+            
             try
             {
-                bestEffortCleanupTarget = SqlInternalConnection.GetBestEffortCleanupTarget(this);
                 statistics = SqlStatistics.StartTimer(Statistics);
                 InnerConnection.ChangeDatabase(database);
             }
-            catch (System.OutOfMemoryException e)
-            {
-                Abort(e);
-                throw;
-            }
-            catch (System.StackOverflowException e)
-            {
-                Abort(e);
-                throw;
-            }
-            catch (System.Threading.ThreadAbortException e)
-            {
-                Abort(e);
-#if NETFRAMEWORK
-                SqlInternalConnection.BestEffortCleanup(bestEffortCleanupTarget);
-#endif
-                throw;
-            }
+            // @TODO: CER Exception Handling was removed here (see GH#3581)
             finally
             {
                 SqlStatistics.StopTimer(statistics);
@@ -1328,15 +1306,10 @@ public override void Close()
                 }
 
                 SqlStatistics statistics = null;
-                TdsParser bestEffortCleanupTarget = null;
                 Exception e = null;
-
-#if NETFRAMEWORK
-                RuntimeHelpers.PrepareConstrainedRegions();
-#endif
+                
                 try
                 {
-                    bestEffortCleanupTarget = SqlInternalConnection.GetBestEffortCleanupTarget(this);
                     statistics = SqlStatistics.StartTimer(Statistics);
 
                     Task reconnectTask = _currentReconnectionTask;
@@ -1362,27 +1335,7 @@ public override void Close()
                         _statistics._closeTimestamp = ADP.TimerCurrent();
                     }
                 }
-                catch (System.OutOfMemoryException ex)
-                {
-                    e = ex;
-                    Abort(ex);
-                    throw;
-                }
-                catch (System.StackOverflowException ex)
-                {
-                    e = ex;
-                    Abort(ex);
-                    throw;
-                }
-                catch (System.Threading.ThreadAbortException ex)
-                {
-                    e = ex;
-                    Abort(ex);
-#if NETFRAMEWORK
-                    SqlInternalConnection.BestEffortCleanup(bestEffortCleanupTarget);
-#endif
-                    throw;
-                }
+                // @TODO: CER Exception Handling was removed here (see GH#3581)
                 catch (Exception ex)
                 {
                     e = ex;

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlInternalConnectionTds.cs

@@ -539,9 +539,6 @@ internal SqlInternalConnectionTds(
             _parserLock.Wait(canReleaseFromAnyThread: false);
             ThreadHasParserLockForClose = true;   // In case of error, let ourselves know that we already own the parser lock
 
-#if NETFRAMEWORK
-            RuntimeHelpers.PrepareConstrainedRegions();
-#endif
             try
             {
                 _timeout = TimeoutTimer.StartSecondsTimeout(connectionOptions.ConnectTimeout);
@@ -573,21 +570,7 @@ internal SqlInternalConnectionTds(
                     }
                 }
             }
-            catch (System.OutOfMemoryException)
-            {
-                DoomThisConnection();
-                throw;
-            }
-            catch (System.StackOverflowException)
-            {
-                DoomThisConnection();
-                throw;
-            }
-            catch (System.Threading.ThreadAbortException)
-            {
-                DoomThisConnection();
-                throw;
-            }
+            // @TODO: CER Exception Handling was removed here (see GH#3581)
             finally
             {
                 ThreadHasParserLockForClose = false;
@@ -2136,39 +2119,19 @@ internal bool GetSessionAndReconnectIfNeeded(SqlConnection parent, int timeout =
 
             try
             {
-#if NETFRAMEWORK
-                RuntimeHelpers.PrepareConstrainedRegions();
-#endif
-                try
+                Task reconnectTask = parent.ValidateAndReconnect(() =>
                 {
-                    Task reconnectTask = parent.ValidateAndReconnect(() =>
-                    {
-                        ThreadHasParserLockForClose = false;
-                        _parserLock.Release();
-                        releaseConnectionLock = false;
-                    }, timeout);
-                    if (reconnectTask != null)
-                    {
-                        AsyncHelper.WaitForCompletion(reconnectTask, timeout);
-                        return true;
-                    }
-                    return false;
-                }
-                catch (System.OutOfMemoryException)
-                {
-                    DoomThisConnection();
-                    throw;
-                }
-                catch (System.StackOverflowException)
-                {
-                    DoomThisConnection();
-                    throw;
-                }
-                catch (System.Threading.ThreadAbortException)
+                    ThreadHasParserLockForClose = false;
+                    _parserLock.Release();
+                    releaseConnectionLock = false;
+                }, timeout);
+                if (reconnectTask != null)
                 {
-                    DoomThisConnection();
-                    throw;
+                    AsyncHelper.WaitForCompletion(reconnectTask, timeout);
+                    return true;
                 }
+                return false;
+                // @TODO: CER Exception Handling was removed here (see GH#3581)
             }
             finally
             {
@@ -2475,10 +2438,6 @@ internal bool TryGetFedAuthTokenLocked(SqlFedAuthInfo fedAuthInfo, DbConnectionP
             // Variable which indicates if we did indeed manage to acquire the lock on the authentication context, to try update it.
             bool authenticationContextLocked = false;
 
-            // Prepare CER to ensure the lock on authentication context is released.
-#if NETFRAMEWORK
-            RuntimeHelpers.PrepareConstrainedRegions();
-#endif
             try
             {
                 // Try to obtain a lock on the context. If acquired, this thread got the opportunity to update.