Skip to content

Commit 1e195f6

Browse files
committed
First code review response
Maintained comment in Dispose method post-merge
1 parent 632b750 commit 1e195f6

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParserStateObjectNative.Windows.cs

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -232,6 +232,11 @@ internal override void Dispose()
232232

233233
if (sessionHandle != null || packetHandle != null)
234234
{
235+
// Comment CloseMARSSession
236+
// UNDONE - if there are pending reads or writes on logical connections, we need to block
237+
// here for the callbacks!!! This only applies to async. Should be fixed by async fixes for
238+
// AD unload/exit.
239+
235240
packetHandle?.Dispose();
236241
asyncAttnPacket?.Dispose();
237242

0 commit comments

Comments
 (0)