Skip to content

Not providing a version for Microsoft.AspNetCore.App results in a package version error #7532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cocowalla opened this issue Jul 10, 2018 — with docs.microsoft.com · 3 comments
Closed

Not providing a version for Microsoft.AspNetCore.App results in a package version error #7532

cocowalla opened this issue Jul 10, 2018 — with docs.microsoft.com · 3 comments
Assignees
@guardrex
Labels
Pri0 Urgent priority Source - Docs.ms Docs Customer feedback via GitHub Issue
Milestone
Sprint 138 (July ...

Comments

@cocowalla docs.microsoft.com
Copy link

See here for a related Github issue.

It would be nice to update these docs and/or fix the problem, to stop others falling into a pit of despair after following this advice to migrate to 2.1

Document details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
@guardrex guardrex self-assigned this Jul 10, 2018
@guardrex guardrex added 2.1.3 Pri2 Source - Docs.ms Docs Customer feedback via GitHub Issue labels Jul 10, 2018
@guardrex
Copy link
Collaborator

They're reversing course on this for 2.1.3. Let's use this issue to track the work.

dotnet/aspnetcore#3292

@Rick-Anderson They're fixing package resolution, and there's nothing wrong with us going ahead with documenting the change now. Thoughts?

@Rick-Anderson Rick-Anderson added Pri0 Urgent priority and removed Pri2 labels Jul 10, 2018
@scottaddie
Copy link
Member

@guardrex My recommendation is to add the Version attribute back to each sample app's project file. That's the direction the product unit is headed, so we should get out ahead of it.

@guardrex
Copy link
Collaborator

Yes, I was just waiting on @Rick-Anderson approval. I'll take care of this today.

@guardrex guardrex removed the 2.1.3 label Jul 10, 2018
@guardrex guardrex mentioned this issue Jul 10, 2018
Merged
scottaddie pushed a commit that referenced this issue Jul 11, 2018
@guardrex @scottaddie
Add version to App package references (#7551)
34b33e2 
Fixes #7532
@dotnet dotnet locked and limited conversation to collaborators Aug 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@guardrex guardrex

Labels
Pri0 Urgent priority Source - Docs.ms Docs Customer feedback via GitHub Issue
Projects
None yet
Milestone
Sprint 138 (July 2 - July 20)
Development

No branches or pull requests
4 participants
@cocowalla @guardrex @Rick-Anderson @scottaddie