Fixed PK NN behavior to match MySQL

Signed-off-by: Daylon Wilkins <[email protected]>

Author: Hydrocharged

engine_test.go

@@ -2515,6 +2515,27 @@ func TestCreateTable(t *testing.T) {
 	}
 
 	require.Equal(s, testTable.Schema())
+
+	testQuery(t, e,
+		"CREATE TABLE t4(a INTEGER,"+
+			"b TEXT NOT NULL,"+
+			"c bool, primary key (a))",
+		[]sql.Row(nil),
+	)
+
+	db, err = e.Catalog.Database("mydb")
+	require.NoError(err)
+
+	testTable, ok = db.Tables()["t4"]
+	require.True(ok)
+
+	s = sql.Schema{
+		{Name: "a", Type: sql.Int32, Nullable: false, PrimaryKey: true, Source: "t4"},
+		{Name: "b", Type: sql.Text, Nullable: false, PrimaryKey: false, Source: "t4"},
+		{Name: "c", Type: sql.Uint8, Nullable: true, Source: "t4"},
+	}
+
+	require.Equal(s, testTable.Schema())
 }
 
 func TestDropTable(t *testing.T) {

sql/parse/parse.go

@@ -545,7 +545,7 @@ func getColumn(cd *sqlparser.ColumnDefinition, indexes []*sqlparser.IndexDefinit
 	}
 
 	return &sql.Column{
-		Nullable:   !bool(typ.NotNull),
+		Nullable:   !isPkey && !bool(typ.NotNull),
 		Type:       internalTyp,
 		Name:       cd.Name.String(),
 		PrimaryKey: isPkey,

sql/parse/parse_test.go

@@ -72,7 +72,7 @@ var fixtures = map[string]sql.Node{
 		sql.Schema{{
 			Name:     "a",
 			Type:     sql.Int32,
-			Nullable: true,
+			Nullable: false,
 			PrimaryKey: true,
 		}, {
 			Name:     "b",
@@ -87,12 +87,12 @@ var fixtures = map[string]sql.Node{
 		sql.Schema{{
 			Name:     "a",
 			Type:     sql.Int32,
-			Nullable: true,
+			Nullable: false,
 			PrimaryKey: true,
 		}, {
 			Name:     "b",
 			Type:     sql.Text,
-			Nullable: true,
+			Nullable: false,
 			PrimaryKey: true,
 		}},
 	),