Skip to content

Compiler fails to start when temporary path contains whitespace #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
agross opened this issue Feb 12, 2012 · 1 comment
Closed

Compiler fails to start when temporary path contains whitespace #18

agross opened this issue Feb 12, 2012 · 1 comment

Comments

@agross
Copy link

agross commented Feb 12, 2012

Tested on Windows. When I run a build with TeamCity $TEMP a path that contains whitespace. TempFile.new copies the compiler jar over there and then tries to run it. That fails because the jarfile path needs escaping.

I don't know if my fix would work in Linux, for Windows at least we need to quote paths.

Perhaps the best way is to let Ruby do the escaping and rather use system *[command, '--js', tempfile.path], check the exit code, or use popen.

@jashkenas
Copy link
Member

Closing in favor of your pull request...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants