Skip to content

Added openj9 builds #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Added openj9 builds #248

wants to merge 1 commit into from

Conversation

smurfy
Copy link

@smurfy smurfy commented Oct 28, 2021

Closes #247

Adds openj9 builds of tomcat based on ibm-semeru-runtimes

@PascalSchumacher
Copy link

Imho it would be great it this was updated to add Java 17 and merged.

@smurfy
Copy link
Author

smurfy commented Dec 17, 2021

It seems ibm-semeru-runtimes just added 17 images, this mr predates this. I will update the MR shortly.

@smurfy
Copy link
Author

smurfy commented Dec 17, 2021

Rebased and ran update.sh to pick up java 17 variants too

@TheWiresharkGuy
Copy link

Any news on this?

@PascalSchumacher
Copy link

It would be great if this was merged.

@tianon
Copy link
Member

tianon commented Nov 29, 2022

Sorry, our current "support matrix" is already out of control, so we're still trying to decide the best path forward. 🙇

To give you an idea the scale I'm talking about, we currently support four concrete versions of Tomcat across ~3 versions of Java (both JDK and JRE) on up to three different implementation+distro combinations. That's ~49 different builds of Tomcat, which is then multiplied by the list of supported architectures for each image we're FROM. 😬

If we take this PR to the extended conclusion, that balloons to ~6 versions of Java (again, ~two builds each, JDK and JRE), from ~5 vendors across even more variants -- I have a test branch that includes those full changes, and it takes the matrix of supported versions from 49 all the way up to 228 (which still doesn't factor in the way the matrix expands along the supported architectures axis -- that's just explicit tag combinations that all support at least amd64). Limiting that to just the three LTS versions of Java takes us down to 147, but that's still really unmanageable (even the 49 we're at now is pretty high up there). 😮‍💨

One thing we've considered is updating the templating to generate all 228 variants, but only officially build/publish one or two "tracks" (perhaps just Temurin, for example). That would take our actual supported list way down, but I wouldn't want to publish that many Dockerfiles unless our automated builds are also testing them, and at 228 we'd be pushing the limits of what GitHub Actions is willing to accept. 😱

So, as you can see, this isn't as simple as just merging this PR. 😞

@ptrecenti
Copy link

ptrecenti commented Nov 29, 2022

So @tianon, instead of supporting multiple matrices of java, tomcat, and vendors.
What do you think about providing a way for vendors to use this repository as of truth to guarantee the tomcat capabilities against releases managed by other people and organizations?

@tianon
Copy link
Member

tianon commented Nov 29, 2022

I'm sorry, I'm afraid I'm having trouble parsing what you mean -- can you elaborate on what concrete change you're proposing?

@tianon
Copy link
Member

tianon commented May 8, 2023

Thanks for the push (and for the implementation suggestions!! 🙇 ❤️); I'm going to close this now in order to consolidate into #299 😅

@tianon tianon closed this May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide openj9 (ibm-semeru-runtimes) based builds
5 participants