Add support for read-only config file mounts #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a pretty common use-case given that as of Kubernetes v1.9.4 configMaps are mounted as read-only. Fixes docker-library#368
This comment has been minimized.
This comment has been minimized.
michaelklishin
approved these changes
Sep 17, 2019
This comment has been minimized.
This comment has been minimized.
yosifkit
approved these changes
Jun 18, 2020
tianon
previously requested changes
Jun 18, 2020
There was a problem hiding this comment.
I agree it's odd that folks are providing a config file and also providing the environment variables that request we write changes to the config file, but it does appear to be a common enough misunderstanding that this seems like a reasonable workaround.
I'm fully on board with deprecating most of this script for RabbitMQ 3.9+.
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jun 23, 2020
Changes: - docker-library/rabbitmq@9effc7f: Update to 3.8.5, Erlang/OTP 23.0.2, OpenSSL 1.1.1g - docker-library/rabbitmq@a5cccf2: Merge pull request docker-library/rabbitmq#369 from st3v/master - docker-library/rabbitmq@34ed62c: touch config file to verify it is read-only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty common use-case given that as of Kubernetes v1.9.4 configMaps are mounted as read-only. See #368 for more details.
Consider this PR as a suggestion for one potential fix. There are probably other ways to address this. I'm not too set on how we address it as long as we do so in the docker image. 😊
Fixes #368