Commit c57ff6e
committed
Slightly refactor new
- align on "bashbrew architectures" for representing the architecture strings (matching the `Architectures:` lines in our downstream `library/rabbitmq` file; this makes it easier to filter that list later if we so choose)
- avoid multi-stage build, especially to avoid the empty file copying/weirdness
- we always need the `rabbitmqadmin` data, so we should query it before the loop (and pre-process it since the data is the same for every single iteration of the loop)
- store `version` in the `rabbitmqadmin` block (our automation uses this for making nicer commit messages like "Update 4.0 to rabbitmqadmin 2.17.1" instead of just "Update 4.0" which is what the current code will lead to)
- use `dpkg --print-architecture` instead of `uname -m` for architecture detection (the former is "userspace architecture" detection, which more closely matches what we need than the latter's "kernel architecture" detection)rabbitmqadmin code1 parent 8e6c07c commit c57ff6e
File tree
12 files changed
+216
-262
lines changed- 3.13
- alpine/management
- ubuntu/management
- 4.0
- alpine/management
- ubuntu/management
- 4.1
- alpine/management
- ubuntu/management
- 4.2
- alpine/management
- ubuntu/management
12 files changed
+216
-262
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | 1 | | |
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments