Update UX and Create Deterministic Build #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeJasinski
approved these changes
Apr 24, 2018
There was a problem hiding this comment.
@alysivji Might be worth putting the JS build instructions in the main README (or at least the main readme can refer to this one). I know that's not part of this PR, but just mentioning. Other than that, look sgood
|
Yah good call. We need to do a bit of cleanup (especially around node modules and building docker images). I'll take a look this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks nice! Thanks Bootstrap!
yarn buildoutputs main.hash.js and main.hash.css and then copies it to the proper folder as main.js / main.css so we can serve via flask.create-react-appdoes not support this functionality, so needed to use a workaround (per create-react-app#821)