Bump redis from 2.10.6 to 3.4.1 #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot-preview[bot]](https://avatars.githubusercontent.com/in/2141?s=60&v=4){kind=small}
dependabot-preview
bot
added
the
dependencies
dependabot-preview
bot
force-pushed
the
dependabot/pip/redis-3.4.1
branch
from
1ef0903 to
11a981e
Compare
i-trofimtschuk
requested review from
a team and
kaloyanm
and removed request for
a team and
kaloyanm
Bumps [redis](https://github.com/andymccurdy/redis-py) from 2.10.6 to 3.4.1. - [Release notes](https://github.com/andymccurdy/redis-py/releases) - [Changelog](https://github.com/andymccurdy/redis-py/blob/master/CHANGES) - [Commits](redis/redis-py@2.10.6...3.4.1) Signed-off-by: dependabot-preview[bot] <[email protected]>
dependabot-preview
bot
force-pushed
the
dependabot/pip/redis-3.4.1
branch
from
11a981e to
e90d89d
Compare
Co-Authored-By: Tatiana Vasilevskaya <[email protected]>
i-trofimtschuk
approved these changes
Mar 26, 2020
vasilty
force-pushed
the
dependabot/pip/redis-3.4.1
branch
from
4f68e9a to
3f7929d
Compare
vasilty
force-pushed
the
dependabot/pip/redis-3.4.1
branch
from
3f7929d to
e51e317
Compare
redis_tasks/registries.py
Outdated
| @@ -114,12 +114,12 @@ def get_dead_ids(self): | |||
| self.key, '-inf', oldest_valid)) | |||
|
|
|||
|
|
|||
| worker_registry = WorkerRegistry() | |||
| worker_registry = LazyObject(lambda: WorkerRegistry()) | |||
There was a problem hiding this comment.
we dont need a lambda here, right?
Suggested change
| worker_registry = LazyObject(lambda: WorkerRegistry()) | |
| worker_registry = LazyObject(WorkerRegistry) |
There was a problem hiding this comment.
right, we could do like so. Thought that that way would be analogous to the rest, but maybe that is not better
redis_tasks/registries.py
Outdated
| @@ -133,4 +133,4 @@ def remove(self, queue, *, pipeline): | |||
| pipeline.srem(self.key, queue.name) | |||
|
|
|||
|
|
|||
| queue_registry = QueueRegistry() | |||
| queue_registry = LazyObject(lambda: QueueRegistry()) | |||
There was a problem hiding this comment.
Suggested change
| queue_registry = LazyObject(lambda: QueueRegistry()) | |
| queue_registry = LazyObject(QueueRegistry) |
i-trofimtschuk
approved these changes
Mar 26, 2020
|
A newer version of redis exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
vasilty
requested review from
i-trofimtschuk and
kaloyanm
and removed request for
Chronial
i-trofimtschuk
approved these changes
May 18, 2020
kaloyanm
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps redis from 2.10.6 to 3.4.1.
Changelog
Sourced from redis's changelog.
Commits
4b7f5623.4.11b05075remove Redis and ConnectionPool eq comparison5a1f3c4Move the username argument in the Redis and Connection classes to the ende39ae45Provide AUTH fallback support for connection URLs with a username componentab1c6593.4.04287963better thread-safety for ConnectionPool (#1270)09a17eaFix spelling in docstring (#1272)a77ad50add type filter to scan function272d313Slight optimization to command packing.9cbb48aAdd test for pipeline.transaction(value_from_callable=True)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Note: This repo was added to Dependabot recently, so you'll receive a maximum of 3 PRs for your first few update runs. Once an update run creates fewer than 3 PRs we'll remove that limit.
You can always request more updates by clicking
Bump nowin your Dependabot dashboard.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labelswill set the current labels as the default for future PRs for this repo and language@dependabot use these reviewerswill set the current reviewers as the default for future PRs for this repo and language@dependabot use these assigneeswill set the current assignees as the default for future PRs for this repo and language@dependabot use this milestonewill set the current milestone as the default for future PRs for this repo and language@dependabot badge mewill comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard: