Code review feedback from review with Nick

Author: portante

lib/pbench/agent/tool_data_sink.py

@@ -649,10 +649,11 @@ def __init__(self, ext_benchmark_run_dir, int_pbench_run):
         # match.
         #
         # E.g.:
-        #  $ benchmark_run_dir = /home/<USER>/run-dir
-        #  $ cat /home/<USER>/run-dir/.path
+        #  $ pbench_run="/home/<USER>/run-dir"
+        #  $ benchmark_run_dir="${pbench_run}/script_config_<date>"
+        #  $ cat ${pbench_run}/.path
         #  /home/<USER>/run-dir
-        #  $ podman run --volume /home/<USER>/run-dir:/var/lib/pbench-agent\
+        #  $ podman run --volume ${pbench_run}:/var/lib/pbench-agent \
         #    pbench-agent-tool-data-sink bash
         #  [ abcdefg /]$ cat /var/lib/pbench-agent/.path
         #  /home/<USER>/run-dir
@@ -664,8 +665,9 @@ def __init__(self, ext_benchmark_run_dir, int_pbench_run):
             benchmark_run_dir_lcl = (
                 self._int_pbench_run / self._ext_benchmark_run_dir.name
             )
+            dot_path = self._int_pbench_run / ".path"
             try:
-                dot_path = (self._int_pbench_run / ".path").read_text().strip()
+                dot_path_contents = dot_path.read_text().strip()
             except Exception as exc:
                 # Failed to read ".path" contents, give up.
                 raise ToolDataSinkError(
@@ -674,11 +676,11 @@ def __init__(self, ext_benchmark_run_dir, int_pbench_run):
                     f".path' not found, '{exc}').",
                 )
             else:
-                if dot_path != str(self._ext_pbench_run):
+                if dot_path_contents != str(self._ext_pbench_run):
                     raise ToolDataSinkError(
                         f"Run directory parameter, '{ext_benchmark_run_dir}',"
                         " must be an existing directory (.path contents"
-                        f" mismatch, .path='{dot_path}' !="
+                        f" mismatch, .path='{dot_path_contents}' !="
                         f" '{self._ext_pbench_run}').",
                     )
         else: