Units testing patience

Author: dbutenhof

lib/pbench/test/unit/server/test_cache_manager.py

@@ -11,6 +11,7 @@
 
 import pytest
 
+from pbench.server import JSONOBJECT
 from pbench.server.cache_manager import (
     BadDirpath,
     BadFilename,
@@ -910,6 +911,32 @@ def test_get_inventory(
             assert file_info["type"] == exp_file_type
             assert file_info["stream"].stream == exp_stream
 
+    def test_cm_inventory(self, monkeypatch, server_config, make_logger):
+        """Verify the happy path of the high level get_inventory"""
+        id = None
+
+        class MockTarball:
+            def get_inventory(self, target: str) -> JSONOBJECT:
+                return {
+                    "name": target,
+                    "type": CacheType.FILE,
+                    "stream": Inventory(io.BytesIO(b"success")),
+                }
+
+        def mock_find_dataset(self, dataset: str) -> MockTarball:
+            nonlocal id
+            id = dataset
+
+            return MockTarball()
+
+        with monkeypatch.context() as m:
+            m.setattr(CacheManager, "find_dataset", mock_find_dataset)
+            cm = CacheManager(server_config, make_logger)
+            inventory = cm.get_inventory("dataset", "target")
+            assert id == "dataset"
+            assert inventory["name"] == "target"
+            assert inventory["stream"].read() == b"success"
+
     def test_tarfile_extract(self, monkeypatch, tmp_path):
         """Test to check Tarball.extract success"""
         tar = Path("/mock/result.tar.xz")

lib/pbench/test/unit/server/test_datasets_inventory.py

@@ -128,3 +128,31 @@ def mock_send_file(path_or_file, *args, **kwargs):
         assert args["as_attachment"] is False
         assert args["download_name"] == "f1.json"
         assert mock_close
+
+    def test_send_fail(self, query_get_as, monkeypatch):
+        mock_close = False
+
+        def mock_close(_s):
+            nonlocal mock_close
+            mock_close = True
+
+        exp_stream = io.BytesIO(b"file_as_a_byte_stream")
+
+        def mock_get_inventory(_s, _d: str, _t: str):
+            return {
+                "name": "f1.json",
+                "type": CacheType.FILE,
+                "stream": Inventory(exp_stream, None),
+            }
+
+        def mock_send_file(path_or_file, *args, **kwargs):
+            raise Exception("I'm failing to succeed")
+
+        monkeypatch.setattr(exp_stream, "close", mock_close)
+        monkeypatch.setattr(CacheManager, "get_inventory", mock_get_inventory)
+        monkeypatch.setattr(
+            "pbench.server.api.resources.datasets_inventory.send_file", mock_send_file
+        )
+
+        query_get_as("fio_2", "f1.json", HTTPStatus.INTERNAL_SERVER_ERROR)
+        assert mock_close