DEV: Autoload and segregate features to prep for migration #341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattsw
commented
Mar 19, 2025
Comment on lines
-35
to
-48
| require_relative "app/controllers/answer_controller" | ||
| require_relative "app/lib/first_accepted_post_solution_validator" | ||
| require_relative "app/lib/accepted_answer_cache" | ||
| require_relative "app/lib/guardian_extensions" | ||
| require_relative "app/lib/before_head_close" | ||
| require_relative "app/lib/category_extension" | ||
| require_relative "app/lib/post_serializer_extension" | ||
| require_relative "app/lib/topic_posters_summary_extension" | ||
| require_relative "app/lib/topic_view_serializer_extension" | ||
| require_relative "app/lib/user_summary_extension" | ||
| require_relative "app/lib/web_hook_extension" | ||
| require_relative "app/serializers/concerns/topic_answer_mixin" | ||
|
|
||
| require_relative "app/lib/plugin_initializers/assigned_reminder_exclude_solved" |
nattsw
commented
Mar 19, 2025
Comment on lines
+418
to
+420
| DiscourseDev::DiscourseSolved.populate(self) | ||
| DiscourseAutomation::EntryPoint.inject(self) if defined?(DiscourseAutomation) | ||
| DiscourseAssign::EntryPoint.inject(self) if defined?(DiscourseAssign) |
tgxworld
reviewed
Mar 19, 2025
app/serializers/concerns/discourse_solved/topic_answer_mixin.rb
Outdated
Show resolved
Hide resolved
tgxworld
reviewed
Mar 19, 2025
tgxworld
approved these changes
Mar 19, 2025
nattsw
added a commit
that referenced
this pull request
Mar 25, 2025
Related: - #309 - #341 Requires: - discourse/discourse#31954 This commit converts all use of post and topic custom fields into a dedicated table: - migration for copying custom field into table - swap app usage of custom fields to table This commit does not attempt to fix issues or optimise, and does not delete old data from custom fields _yet_.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR autoloads plugin files, and also extracts features into their own modules.
plugin.rbis smallerThis is to prepare for the "custom fields" -> "table" move, which is done to allow the feature to show which user marked an answer as reply.
Ideally, we should have a subsequent PR that consolidates wherever custom fields are used since they are now sprinkled everywhere 😮💨 making the migration more tedious than it should.