Skip to content

FIX: Optimise and update queries, shorter frequency #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 26, 2025
Merged

FIX: Optimise and update queries, shorter frequency #20

merged 2 commits into from
Mar 26, 2025

Conversation

nattsw
Copy link
Contributor

@nattsw nattsw commented Mar 26, 2025 •
edited
Loading

This PR solves a few issues:

  • Currently due to the 14.day schedule, any sites with remind_mark_solution_last_post_age of 1 will not be able to receive notifications. This bumps the frequency to a day
  • On a site with hundreds of thousands of topics, this loads all the ids into memory unsolved_topic_ids.push(*Topic.where(category_id: category_ids).pluck(:id)) 😱
  • Many plucks (N+1)
  • (Potentially) Large array subtractions are inefficient and could be done in the database
  • Moves to custom fields as per DEV: Move solved custom fields into a table discourse-solved#342

dbattersby
dbattersby approved these changes Mar 26, 2025
View reviewed changes
Copy link

@dbattersby dbattersby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@nattsw nattsw merged commit be146b2 into main Mar 26, 2025
3 checks passed
@nattsw nattsw deleted the job-schedule branch March 26, 2025 07:23
@nattsw nattsw mentioned this pull request Apr 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbattersby dbattersby dbattersby approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nattsw @dbattersby