feat: @discordjs/redis-gateway #9541
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
didinele
force-pushed
the
feat/discord-redis-gateway
branch
from
cc74ecb to
cfbd679
Compare
didinele
force-pushed
the
feat/discord-redis-gateway
branch
from
dbdd44d to
73ba97a
Compare
Codecov Report
@@ Coverage Diff @@
## main #9541 +/- ##
==========================================
+ Coverage 58.64% 58.65% +0.01%
==========================================
Files 226 226
Lines 14790 14786 -4
Branches 1132 1132
==========================================
Hits 8673 8673
+ Misses 6077 6073 -4
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
didinele
force-pushed
the
feat/discord-redis-gateway
branch
from
73ba97a to
66497f1
Compare
iCrawl
approved these changes
May 8, 2023
Jiralite
reviewed
May 8, 2023
Co-authored-by: Jiralite <[email protected]>
vladfrangu
requested changes
May 8, 2023
Co-authored-by: Vlad Frangu <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a Redis-based gateway package to handle Discord events using a Redis broker. Additionally, it updates Docker publish workflows, module exports, and label configurations to integrate and support the new package.
- Introduces the RedisGateway implementation for sending and receiving gateway events via Redis.
- Updates Docker workflows and label configurations to include the new @discordjs/redis-gateway package.
- Refactors module exports in core and client files to integrate the new gateway functionality.
Reviewed Changes
Copilot reviewed 23 out of 32 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/gateway/RedisGateway.ts | Adds the RedisGateway implementation using a Redis broker for handling gateway events. |
| packages/redis-gateway/.lintstagedrc.cjs | Configures lint-staged for the new redis-gateway package. |
| .github/workflows/publish-dev-docker.yml | Adds a matrix strategy to publish Docker images for redis-gateway and proxy-container packages. |
| .github/workflows/publish-docker.yml | Enhances Docker publish workflow by including the redis-gateway package in the build matrix. |
| packages/core/src/index.ts | Updates module exports to include the new Gateway and RedisGateway modules. |
| .github/labeler.yml, .github/labels.yml, .github/issue-labeler.yml | Adds label configurations for the redis-gateway package. |
| packages/core/src/gateway/Gateway.ts | Adds documentation for the Gateway interface to support both core and Redis-based gateways. |
| packages/core/src/client.ts | Refactors client event mappings and TypeScript types, removing legacy event definitions. |
| packages/proxy-container/README.md | Removes a redundant documentation link in the proxy container README. |
Files not reviewed (9)
- .github/CODEOWNERS: Language not supported
- packages/brokers/LICENSE: Language not supported
- packages/core/package.json: Language not supported
- packages/proxy-container/LICENSE: Language not supported
- packages/proxy-container/tsconfig.json: Language not supported
- packages/proxy/LICENSE: Language not supported
- packages/redis-gateway/.eslintrc.json: Language not supported
- packages/redis-gateway/.gitignore: Language not supported
- packages/redis-gateway/.prettierignore: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
new package pog
🤖 Generated by Copilot at 73ba97a
few notes:
core's newGateway