-
Notifications
You must be signed in to change notification settings - Fork 472
Duplicate clean
task
#521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is where we "create" the spotless/plugin-gradle/src/main/java/com/diffplug/gradle/spotless/SpotlessPlugin.java Lines 31 to 38 in c007dba
I think the way we're doing it now is the conventional way which plays nice with other plugins. I think it would look like this for your example apply plugin: BasePlugin
tasks.getByName(BasePlugin.CLEAN_TASK_NAME).doLast {
delete rootProject.buildDir
} |
Can this be better documented? I'm fine with it, but it basically creates an error for any project that kept the default template until a change is made |
A quick git blame shows that the line I linked to above is at least 2 years old, and it looks like |
Happy to reopen if there's further action or discussion to be had. |
As of spotless
3.27.0
, it seems like aclean
task is created. I'm not sure about now, but at least a year ago, all new projects had aclean
task created by the IDE by default:The fix for us is to remove the inline
clean
task.If this is expected, consider adding this in the changelog. If this is not expected, can we avoid the naming conflict somehow?
The text was updated successfully, but these errors were encountered: