expr2smv: enum for precedence #708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
approved these changes
Sep 20, 2024
src/smvlang/expr2smv.cpp
Outdated
| UNION = 10, // union | ||
| IN = 9, // in | ||
| REL = 8, // = != < > <= >= | ||
| TEMP = 7, // AX, AF, etc. |
There was a problem hiding this comment.
Perhaps spell out "TEMPORAL" on this occasion? When reading the code I found myself thinking "wait, is there some sort of temporary precedence?"
kroening
force-pushed
the
smv-prec
branch
3 times, most recently
from
55e10d0 to
2a8f28f
Compare
This replaces the use of 'unsigned' and assorted integer literals for the expression precedence by an enum type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the use of
unsignedand assorted integer literals for the expression precedence by an enum type.