BMC: encode properties using timeframe/handle pair #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
approved these changes
Mar 25, 2024
kroening
force-pushed
the
bmc_obligationst
branch
from
b557160 to
1754d78
Compare
tautschnig
reviewed
Mar 25, 2024
| @@ -115,7 +115,45 @@ void property( | |||
| instantiate(p, c, no_timeframes, ns); | |||
|
|
|||
| auto handle = solver.handle(tmp); | |||
| prop_handles.push_back(std::move(handle)); | |||
| obligations[c].push_back(std::move(handle)); | |||
There was a problem hiding this comment.
I guess this isn't really a hot path, but this could safely be written as
obligations.insert(c, {solver.handle(tmp)});as each index is unique. I'm actually no longer sure why this needs to be exprt::operandst as value type when it can only ever be a single exprt?
There was a problem hiding this comment.
Give me a sec, there will be more than one expression per index, and they'll come separately.
tautschnig
reviewed
Mar 25, 2024
src/trans-word-level/property.cpp
Outdated
| @@ -87,14 +88,13 @@ void property( | |||
| property_expr.id() == ID_sva_nexttime || | |||
| property_expr.id() == ID_sva_s_nexttime) | |||
| { | |||
| prop_handles.resize(no_timeframes, true_exprt()); | |||
| if(no_timeframes > 0) | |||
There was a problem hiding this comment.
Not really for this PR, but still wondering: is no_timeframes == 0 actually a legitimate case at all? Should this perhaps be ruled out via a PRECONDITION?
There was a problem hiding this comment.
Yes, I'll make it a PRECONDITION. BMC without any timeframes is not a thing.
The property encoding interface is changed to return a timeframe/handle pair, instead of just a condition per timeframe. This allows determining the appropriate size of the counterexample trace.
kroening
force-pushed
the
bmc_obligationst
branch
from
1754d78 to
0158a8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The property encoding interface is changed to return a timeframe/handle pair, instead of just a condition per timeframe.
This allows determining the appropriate size of the counterexample trace.