Skip to content

SVA: sequence expressions should have sequence type #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025
Merged

SVA: sequence expressions should have sequence type #1082

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions src/verilog/sva_expr.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,14 +783,15 @@ static inline sva_and_exprt &to_sva_and_expr(exprt &expr)
return static_cast<sva_and_exprt &>(expr);
}

class sva_sequence_concatenation_exprt : public binary_predicate_exprt
class sva_sequence_concatenation_exprt : public binary_exprt
{
public:
explicit sva_sequence_concatenation_exprt(exprt op0, exprt op1)
: binary_predicate_exprt(
: binary_exprt(
std::move(op0),
ID_sva_sequence_concatenation,
std::move(op1))
std::move(op1),
verilog_sva_sequence_typet{})
{
}
};
Expand Down Expand Up @@ -925,7 +926,7 @@ class sva_cycle_delay_exprt : public ternary_exprt
std::move(from),
std::move(to),
std::move(op),
bool_typet())
verilog_sva_sequence_typet{})
{
}

Expand All @@ -935,7 +936,7 @@ class sva_cycle_delay_exprt : public ternary_exprt
std::move(cycles),
nil_exprt{},
std::move(op),
bool_typet())
verilog_sva_sequence_typet{})
{
}

Expand Down Expand Up @@ -1001,7 +1002,10 @@ class sva_cycle_delay_plus_exprt : public unary_exprt
{
public:
explicit sva_cycle_delay_plus_exprt(exprt op)
: unary_exprt(ID_sva_cycle_delay_plus, std::move(op), bool_typet())
: unary_exprt(
ID_sva_cycle_delay_plus,
std::move(op),
verilog_sva_sequence_typet{})
{
}
};
Expand All @@ -1026,7 +1030,10 @@ class sva_cycle_delay_star_exprt : public unary_exprt
{
public:
explicit sva_cycle_delay_star_exprt(exprt op)
: unary_exprt(ID_sva_cycle_delay_star, std::move(op), bool_typet())
: unary_exprt(
ID_sva_cycle_delay_star,
std::move(op),
verilog_sva_sequence_typet{})
{
}
};
Expand Down Expand Up @@ -1372,7 +1379,7 @@ class sva_sequence_goto_repetition_exprt : public binary_exprt
std::move(__op),
ID_sva_sequence_goto_repetition,
std::move(__repetitions),
bool_typet{}}
verilog_sva_sequence_typet{}}
{
}

Expand Down Expand Up @@ -1428,7 +1435,7 @@ class sva_sequence_non_consecutive_repetition_exprt : public binary_exprt
std::move(__op),
ID_sva_sequence_non_consecutive_repetition,
std::move(__repetitions),
bool_typet{}}
verilog_sva_sequence_typet{}}
{
}

Expand Down
Loading