SVA to LTL now converts SVA sequences #1066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
SVA_sequence_to_LTL
branch
2 times, most recently
from
65c1a05 to
a1532fa
Compare
|
This one needs a rebase. |
kroening
force-pushed
the
SVA_sequence_to_LTL
branch
2 times, most recently
from
d5a0bf6 to
fe29963
Compare
|
Done |
kroening
force-pushed
the
SVA_sequence_to_LTL
branch
2 times, most recently
from
833ecb5 to
af2af67
Compare
tautschnig
approved these changes
Apr 24, 2025
Comment on lines
285
to
320
| if(delay.to().is_nil()) | ||
| { | ||
| for(auto &match : matches) | ||
| { | ||
| // delay as instructed | ||
| match.length += from_int; | ||
| match.cond = n_Xes(from_int, match.cond); | ||
| } | ||
| return matches; | ||
| } | ||
| else | ||
| return {}; |
There was a problem hiding this comment.
Wouldn't the upper bound on delay just mean that after such delay we want the negation of match.cond to hold?
There was a problem hiding this comment.
It only says that the match has to happen in that interval, no claim is made about what happens after that interval.
I'll add a for loop.
kroening
force-pushed
the
SVA_sequence_to_LTL
branch
from
af2af67 to
56152fe
Compare
This adds support for mapping some SVA sequences to equivalent LTL.
kroening
force-pushed
the
SVA_sequence_to_LTL
branch
from
56152fe to
ec7e96a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for mapping some SVA sequences to equivalent LTL.