Skip to content

Do cu specs #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed

Do cu specs #82

wants to merge 16 commits into from

Conversation

tjj2017
Copy link
Collaborator

@tjj2017 tjj2017 commented Nov 27, 2018

This branch implements the processing of "withed" units.
Currently only subprogram_declarations, subprogram_bodies and package_declarations are handled.
(No generic declarations or task declarations)
There are many declarations that can be declared within these units which are not handled.

…o file instead of stdout.

Still wrote to symbol table to std out when compiling a package body.
…om withed units into the symbol table.

This code is experimental and contains some print statements for monitoring and debugging.
…ation for compiling package specifications.

Simplifies seeing what is implemented and what is not.
Should make it simpler to split the handling of declarations and statements into two private child packages.
# Conflicts:
#	gnat2goto/driver/tree_walk.adb
Conflicts resolved - compiles and runs ok
Added N_Number_Declaration as a permitted Nkind to precondition of Process_Declarations
Remove precondition from Process_Declaration as not all the possible node types have been determined yet.
…s many declarations that are not currently handled.
@chrisr-diffblue
Copy link
Contributor

@tjj2017 Many thanks for this large contribution! Could I ask for a couple of things to be done before we review it fully:

  • Could you rebase it on the latest master branch
  • There is currently two 'merge commits' in the list of commits for this PR - could you remove those please? (they will likely go away with the rebase, but its worth checking) We prefer not to have merge commits in PR's because it makes for a messy commit history
  • Check whether any commits should be squashed together - e.g. if you have introduced diagnostic print statements in one commit, and then in a later commit removed them, those two commits should most likely be squashed together.

Thanks again for your efforts, an we'll look forward to reviewing it fully!

@tjj2017
Copy link
Collaborator Author

tjj2017 commented Apr 18, 2019

The conflicts associated with this branch have been resolved and merged via a new branch associated with PR #113

@tjj2017 tjj2017 closed this Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants