[goto-cc] Add support for ARM-enabling flags #957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested changes
May 23, 2017
.gitignore
Outdated
| @@ -37,6 +37,7 @@ src/ansi-c/gcc_builtin_headers_power.inc | |||
| regression/**/tests.log | |||
| regression/**/*.gb | |||
| regression/**/*.smt2 | |||
| regression/ansi-c/arch_flags*/linked-object | |||
There was a problem hiding this comment.
I'd get rid of this, more below.
| @@ -0,0 +1,20 @@ | |||
| CORE | |||
| preproc.i | |||
| -mcpu=cortex-a15 -o linked-object object.intel | |||
There was a problem hiding this comment.
Name the output file "linked-object.gb" as the .gb suffix will ensure 1) the gitignore matches and 2) make clean removes it.
| -- | ||
| This tests the -mcpu=cortex=a15 flag that should activate ARM-32 mode. | ||
| The object file 'object.intel' was compiled from 'source.c' with goto-cc | ||
| as usual: |
There was a problem hiding this comment.
Possibly add "on a 64-bit platform".
| @@ -0,0 +1,19 @@ | |||
| CORE | |||
| preproc.i | |||
| -mcpu=cortex-a15 -o linked-object object.arm | |||
| @@ -0,0 +1,19 @@ | |||
| CORE | |||
| preproc.i | |||
| -mthumb -o linked-object object.intel | |||
| @@ -0,0 +1,19 @@ | |||
| CORE | |||
| preproc.i | |||
| -mthumb -o linked-object object.arm | |||
src/goto-cc/gcc_mode.cpp
Outdated
| } | ||
| } | ||
|
|
||
| end_arch: |
There was a problem hiding this comment.
Don't use goto. Well, we should actually codify that in the CODING_STANDARD.
src/goto-cc/gcc_mode.cpp
Outdated
| /* -mcpu sets both the arch and tune, but should only be used if | ||
| * neither -march nor -mtune are passed on the command line. | ||
| */ | ||
| std::string target_cpu = |
goto-cc now accepts the following flags:
-mthumb{,-interwork}
-mcpu=PROC
-march=PROC
-mtune=PROC
where PROC is one of the (many) processors that GCC accepts for those
three arguments.
Supplying one or more of these flags causes goto-cc to switch to the
mode of that architecture, i.e. by changing output code format, sizes of
pointers and integers, etc. Thus, passing (for example) -mcpu=cortex-a15
is enough to make goto-cc generate ARM-32 code; there is no longer any
need to pass -m32.
tautschnig
approved these changes
May 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goto-cc now accepts the following flags:
-mthumb{,-interwork}
-mcpu=PROC
-march=PROC
-mtune=PROC
where PROC is one of the (many) processors that GCC accepts for those
three arguments.
Supplying one or more of these flags causes goto-cc to switch to the
mode of that architecture, i.e. by changing output code format, sizes of
pointers and integers, etc. Thus, passing (for example) -mcpu=cortex-a15
is enough to make goto-cc generate ARM-32 code; there is no longer any
need to pass -m32.
CR: https://cr.amazon.com/r/7156058/