run(..., std::ostream &, ...)
with pipe
#8650
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run(...)
has a variant that that accepts anstd::ostream
for the stdout redirection. This replaces the use ofpopen(...)
in this variant by a standard combination ofpipe
/fork
/exec
.The benefit is this change is that the use of a shell is avoided, which is difficult to secure owing to the parsing of the command by the shell.