implement boolbvt::get for enumeration types #8589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
requested review from
martin-cs,
tautschnig and
peterschrammel
as code owners
peterschrammel
approved these changes
Feb 10, 2025
| else if(type.id() == ID_enumeration) | ||
| { | ||
| auto &elements = to_enumeration_type(type).elements(); | ||
| mp_integer int_value = binary2integer(value, false); |
There was a problem hiding this comment.
No, binary2integer(..., false) won't return a negative value.
| mp_integer int_value = binary2integer(value, false); | ||
| irep_idt element; | ||
| if(int_value >= elements.size()) | ||
| element = irep_idt{}; |
There was a problem hiding this comment.
❓ Where will we fall over when encountering this?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8589 +/- ##
===========================================
+ Coverage 78.71% 79.59% +0.88%
===========================================
Files 1732 1733 +1
Lines 199536 197389 -2147
Branches 18281 18166 -115
===========================================
+ Hits 157057 157111 +54
+ Misses 42479 40278 -2201 ☔ View full report in Codecov by Sentry. |
kroening
force-pushed
the
enumeration_bv_get
branch
from
6d0a7aa to
7451e83
Compare
This adds the missing implementation for getting values from models for enumeration types.
kroening
force-pushed
the
enumeration_bv_get
branch
from
7451e83 to
b4f9748
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the missing implementation for getting values from models for enumeration types.