Skip to content

SMT2: implement cond #8467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2024
Merged

SMT2: implement cond #8467

merged 1 commit into from
Dec 17, 2024

Conversation

kroening
Copy link
Member

This adds support for cond_exprt, via a lowering to nested ?:, to the SMT backend.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening kroening marked this pull request as ready for review September 23, 2024 18:57
@kroening
Copy link
Member Author

cond is also an SMV-only construct; it would likely be a candidate for removal once the solver architecture becomes pluggable.

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 78.93%. Comparing base (fa299c5) to head (19958fe).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
src/util/std_expr.cpp 0.00% 12 Missing ⚠️
src/solvers/smt2/smt2_conv.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8467      +/-   ##
===========================================
+ Coverage    78.63%   78.93%   +0.29%     
===========================================
  Files         1728     1728              
  Lines       199408   198649     -759     
  Branches     18316    18355      +39     
===========================================
- Hits        156797   156795       -2     
+ Misses       42611    41854     -757     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This adds support for cond_exprt, via a lowering to nested ?:, to the SMT
backend.
@kroening kroening enabled auto-merge December 17, 2024 21:00
@kroening kroening merged commit 436ed5d into develop Dec 17, 2024
37 of 41 checks passed
@kroening kroening deleted the smt2-cond branch December 17, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants