Skip to content

C/C++ front-end: Revert scanner re-entrancy #8245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

tautschnig
Copy link
Collaborator

There is no need for scanner re-entrancy, and using flex' re-entrancy options fails the build on some macOS configurations. Partly reverts 1f240bc.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 63.88443% with 225 lines in your changes are missing coverage. Please review.

Project coverage is 79.64%. Comparing base (1fd7011) to head (08d6d67).

Files Patch % Lines
src/ansi-c/scanner.l 29.95% 145 Missing ⚠️
src/ansi-c/parser.y 79.69% 80 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8245   +/-   ##
========================================
  Coverage    79.64%   79.64%           
========================================
  Files         1684     1684           
  Lines       195606   195582   -24     
========================================
- Hits        155791   155777   -14     
+ Misses       39815    39805   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig force-pushed the no-reentrant-c-scanner branch from c418c17 to 447413d Compare March 18, 2024 09:52
There is no need for scanner re-entrancy, and using flex' re-entrancy
options fails the build on some macOS configurations. Partly reverts
1f240bc.
@tautschnig tautschnig force-pushed the no-reentrant-c-scanner branch from 447413d to 08d6d67 Compare March 18, 2024 14:30
@kroening kroening merged commit c7d8e2e into diffblue:develop Mar 18, 2024
@tautschnig tautschnig deleted the no-reentrant-c-scanner branch March 19, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants