Skip to content

remove_returns: do not lose location numbers #8178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tautschnig
Copy link
Collaborator

Fully replacing an instruction would also invalidate its location number. This isn't necessary here, and we also didn't run compute_location_numbers after this change.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Fully replacing an instruction would also invalidate its location
number. This isn't necessary here, and we also didn't run
compute_location_numbers after this change.
@tautschnig tautschnig force-pushed the bugfixes/remove-returns-loc-nr branch from 777e491 to a235b44 Compare February 2, 2024 13:56
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f034dbb) 79.69% compared to head (a235b44) 79.69%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8178   +/-   ##
========================================
  Coverage    79.69%   79.69%           
========================================
  Files         1680     1680           
  Lines       195242   195242           
========================================
  Hits        155604   155604           
  Misses       39638    39638           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig merged commit 5d85d38 into diffblue:develop Feb 2, 2024
@tautschnig tautschnig deleted the bugfixes/remove-returns-loc-nr branch February 2, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants