Skip to content

simplify prop_conv_solvert::push #8122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2023
Merged

simplify prop_conv_solvert::push #8122

merged 1 commit into from
Dec 19, 2023

Conversation

kroening
Copy link
Member

This change relieves the user of prop_conv_solvert::push from the restriction that the expressions pushed as assumptions must be literal_exprt and frozen.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This change relieves the user of prop_conv_solvert::push from the
restriction that the expressions pushed as assumptions must be
literal_exprt and frozen.
@kroening kroening marked this pull request as ready for review December 19, 2023 11:15
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a1272a) 79.09% compared to head (00e5975) 79.08%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8122      +/-   ##
===========================================
- Coverage    79.09%   79.08%   -0.01%     
===========================================
  Files         1697     1697              
  Lines       196490   196493       +3     
===========================================
- Hits        155407   155395      -12     
- Misses       41083    41098      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kroening kroening merged commit 92e3c0f into develop Dec 19, 2023
@kroening kroening deleted the push_literal_exprt branch December 19, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants