Replace file_util.{h,cpp} by std::filesystem #8033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
martin-cs,
peterschrammel,
kroening and
TGWDB
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #8033 +/- ##
===========================================
- Coverage 79.09% 79.08% -0.01%
===========================================
Files 1699 1697 -2
Lines 196512 196437 -75
===========================================
- Hits 155428 155362 -66
+ Misses 41084 41075 -9 ☔ View full report in Codecov by Sentry. |
NlightNFotis
approved these changes
Nov 14, 2023
| @@ -303,9 +303,9 @@ int as_modet::as_hybrid_binary(const compilet &compiler) | |||
| std::string saved = output_file + ".goto-cc-saved"; | |||
| try | |||
| { | |||
| file_rename(output_file, saved); | |||
| std::filesystem::rename(output_file, saved); | |||
There was a problem hiding this comment.
Do we have any tests for this (even manual)? The codecov warning is a bit concerning when refactoring bits like that, which follow some diverging codepaths like exceptions being triggered, etc.
There was a problem hiding this comment.
I think the only time this is genuinely put to a test at the moment is the "Build Xen with CPROVER tools" CI job. We don't have regression tests for goto-as (as_modet) at this time.
esteffin
approved these changes
Nov 15, 2023
With C++ 17 we can use the STL-provided implementation instead of rolling our own (platform-dependent) code.
tautschnig
force-pushed
the
cleanup/filesystem
branch
from
7f2f46b to
5664950
Compare
peterschrammel
approved these changes
Dec 15, 2023
kroening
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With C++ 17 we can use the STL-provided implementation instead of rolling our own (platform-dependent) code.