Skip to content

Remove local declaration of void_t #8031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

tautschnig
Copy link
Collaborator

With the move to C++ 17 we can use std::void_t instead.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

With the move to C++ 17 we can use std::void_t instead.
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a8de0b7) 79.10% compared to head (ab81bbd) 79.09%.
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8031      +/-   ##
===========================================
- Coverage    79.10%   79.09%   -0.01%     
===========================================
  Files         1699     1699              
  Lines       196508   196508              
===========================================
- Hits        155443   155430      -13     
- Misses       41065    41078      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tautschnig tautschnig assigned tautschnig and unassigned TGWDB Nov 14, 2023
@thomasspriggs thomasspriggs merged commit 3db3e49 into diffblue:develop Nov 14, 2023
@tautschnig tautschnig deleted the cleanup/void_t branch November 14, 2023 15:03
@thomasspriggs
Copy link
Contributor

@tautschnig Hope you don't mind me merging this. I want to raise this PR based on top of it - #8035

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants