Stop building memory-analyzer on Mac and Windows

[esteffin]

This PR fixes an issue when trying to build memory-analyzer on Apple Silicon machines by excluding it on Windows and Apple systems.

This also was the expected behaviour for it.

Fixes Issue #7922

• Each commit message has a non-empty body, explaining why the change was made.
• Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
• The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
• Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
• My commit message includes data points confirming performance improvements (if claimed).
• My PR is restricted to a single feature or bugfix.
• White-space or formatting changes outside the feature-related changed lines are in commits of their own.

[tautschnig]

Can we please also change src/Makefile to do

ifeq ($(WITH_MEMORY_ANALYZER),1)
  all: memory-analyzer.dir
else ifneq ($(filter-out Windows Darwin,$(detected_OS)),)
  all: memory-analyzer.dir
endif

instead of the current Linux-only logic?

[thomasspriggs]

Should this be built for Apple + Intel builds?

[tautschnig]

Should this be built for Apple + Intel builds?

macOS has lldb instead of gdb, and I have no idea whether our interface with gdb ports to that. So I'd say no. (But of course someone could sit down and try and make this work...)

[esteffin]

Should this be built for Apple + Intel builds?

Even if the module is not enabled by default, it is possible to compile it in any system by using WITH_MEMORY_ANALYZER

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (10c4bca) 78.91% compared to head (b62b90b) 79.00%.
Report is 5 commits behind head on develop.

❗ Current head b62b90b differs from pull request most recent head d824acc. Consider uploading reports for the commit d824acc to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #7923      +/-   ##
===========================================
+ Coverage    78.91%   79.00%   +0.08%     
===========================================
  Files         1697     1697              
  Lines       195418   195418              
===========================================
+ Hits        154211   154384     +173     
+ Misses       41207    41034     -173     

see 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[NlightNFotis]

lldb to my knowledge uses different commands than gdb, so making it work is a fairly elaborate exercise.

We probably shouldn't consider it as part of this change.