Skip to content

Fix byte update of struct/array elements #7855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

tautschnig
Copy link
Collaborator

A key part of this is factoring out code that was almost-the-same from lower_byte_update_array_vector and lower_byte_update_struct, but actually had subtle bugs as documented in regression test included in this commit.

For consistency, do all offset calculations in bits rather than flipping back and forth between bits and bytes.

This will fix the spurious failure reported in model-checking/kani#2650.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig added bugfix aws Bugs or features of importance to AWS CBMC users aws-high Kani Bugs or features of importance to Kani Rust Verifier labels Aug 18, 2023
A key part of this is factoring out code that was almost-the-same from
lower_byte_update_array_vector and lower_byte_update_struct, but
actually had subtle bugs as documented in regression test included in
this commit.

For consistency, do all offset calculations in bits rather than flipping
back and forth between bits and bytes.
@tautschnig tautschnig force-pushed the bugfixes/byte-update-members branch from fd26dba to 5e907b0 Compare August 18, 2023 08:08
@kroening kroening merged commit 1c52e3c into diffblue:develop Sep 18, 2023
@tautschnig tautschnig deleted the bugfixes/byte-update-members branch September 18, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws Bugs or features of importance to AWS CBMC users aws-high bugfix Kani Bugs or features of importance to Kani Rust Verifier
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants