Skip to content

Turns off using lambdas for array comprehension #7838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

TGWDB
Copy link
Contributor

@TGWDB TGWDB commented Aug 3, 2023

Using lambdas for array comprehension can cause errors in get-value operations later.

Fixes #7767

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (1ecce42) 78.79% compared to head (881523b) 78.81%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7838      +/-   ##
===========================================
+ Coverage    78.79%   78.81%   +0.01%     
===========================================
  Files         1698     1698              
  Lines       194641   194640       -1     
===========================================
+ Hits        153374   153397      +23     
+ Misses       41267    41243      -24     
Files Changed Coverage Δ
src/solvers/smt2/smt2_conv.cpp 71.49% <ø> (+0.79%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TGWDB TGWDB force-pushed the 20230803-disable-z3-lambda-for-array-comprehension branch 2 times, most recently from 6701979 to 3c724d6 Compare August 3, 2023 14:28
Using lambdas for array comprehension can cause errors in
get-value operations later.

Fixes #7767
@TGWDB TGWDB force-pushed the 20230803-disable-z3-lambda-for-array-comprehension branch from 3c724d6 to 881523b Compare August 3, 2023 14:51
@kroening
Copy link
Member

kroening commented Aug 4, 2023

Please don't merge; this needs a fix that retains the array comprehension functionality.

@TGWDB TGWDB closed this Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get-value errors with the smt2 backend when assertions have quantifiers
3 participants