Skip to content

Replace DFCC's set_hide by call to make_hidden #7681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tautschnig
Copy link
Collaborator

We don't need to mark each instruction as hidden for goto-symex will pick up the is-hidden marker from the goto_functiont containing the instruction(s).

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

We don't need to mark each instruction as hidden for goto-symex will
pick up the is-hidden marker from the goto_functiont containing the
instruction(s).
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (f39a5c1) 78.52% compared to head (492b06f) 78.50%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7681      +/-   ##
===========================================
- Coverage    78.52%   78.50%   -0.02%     
===========================================
  Files         1674     1674              
  Lines       191971   191961      -10     
===========================================
- Hits        150738   150708      -30     
- Misses       41233    41253      +20     
Impacted Files Coverage Δ
...instrument/contracts/dynamic-frames/dfcc_utils.cpp 86.78% <ø> (-0.28%) ⬇️
...o-instrument/contracts/dynamic-frames/dfcc_utils.h 0.00% <ø> (ø)
...strument/contracts/dynamic-frames/dfcc_library.cpp 93.64% <100.00%> (-0.08%) ⬇️
...t/contracts/dynamic-frames/dfcc_spec_functions.cpp 91.81% <100.00%> (ø)
...nt/contracts/dynamic-frames/dfcc_swap_and_wrap.cpp 86.36% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tautschnig tautschnig merged commit b1abd41 into diffblue:develop Apr 21, 2023
@tautschnig tautschnig deleted the cleanup/remove-dfcc-set_hide branch April 21, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants