Skip to content

Constructor/destructor attributes also work with forward declarations #7601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

tautschnig
Copy link
Collaborator

GCC and Clang accept and apply these attributes when they are part of the forward declaration, the definition, or both.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

GCC and Clang accept and apply these attributes when they are part of
the forward declaration, the definition, or both.
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4af9c8a) 78.51% compared to head (b1cd9e2) 78.51%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7601   +/-   ##
========================================
  Coverage    78.51%   78.51%           
========================================
  Files         1670     1670           
  Lines       191787   191791    +4     
========================================
+ Hits        150574   150578    +4     
  Misses       41213    41213           
Impacted Files Coverage Δ
src/ansi-c/c_typecheck_base.cpp 83.26% <100.00%> (+0.12%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@peterschrammel peterschrammel removed their assignment Mar 21, 2023
@tautschnig tautschnig merged commit 7c95385 into diffblue:develop Mar 21, 2023
@tautschnig tautschnig deleted the bugfixes/constructor-2 branch March 21, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants