Skip to content

Constructor attribute is not required with forward declaration #7594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

tautschnig
Copy link
Collaborator

GCC happily accepts constructor (and destructor) definitions when an earlier forward declaration did not have any such attribute.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

GCC happily accepts constructor (and destructor) definitions when an
earlier forward declaration did not have any such attribute.
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (3cf1ade) 78.48% compared to head (7c41e4d) 78.50%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7594      +/-   ##
===========================================
+ Coverage    78.48%   78.50%   +0.02%     
===========================================
  Files         1670     1670              
  Lines       191775   191777       +2     
===========================================
+ Hits        150509   150554      +45     
+ Misses       41266    41223      -43     
Impacted Files Coverage Δ
src/ansi-c/c_typecheck_base.cpp 83.13% <100.00%> (+0.06%) ⬆️

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tautschnig tautschnig merged commit cf084e6 into diffblue:develop Mar 13, 2023
@tautschnig tautschnig deleted the bugfixes/constructor branch March 13, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants