Skip to content

goto-gcc/goto-ld: reproduce original help output #7588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

tautschnig
Copy link
Collaborator

There are configure scripts that parse the --help output to obtain the set of supported targets. Without the original output those build systems are then led to believe that we don't support shared libraries (which in turn breaks some builds).

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@9be731d). Click here to learn what that means.
Patch coverage: 55.55% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #7588   +/-   ##
==========================================
  Coverage           ?   78.50%           
==========================================
  Files              ?     1670           
  Lines              ?   191770           
  Branches           ?        0           
==========================================
  Hits               ?   150552           
  Misses             ?    41218           
  Partials           ?        0           
Impacted Files Coverage Δ
src/goto-cc/gcc_mode.cpp 68.52% <40.00%> (ø)
src/goto-cc/ld_mode.cpp 36.84% <75.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tautschnig
Copy link
Collaborator Author

tautschnig commented Mar 12, 2023

See #7590 for the test failure. (Edit: merged, PR rebased.)

@tautschnig tautschnig self-assigned this Mar 12, 2023
There are configure scripts that parse the --help output to obtain the
set of supported targets. Without the original output those build
systems are then led to believe that we don't support shared libraries
(which in turn breaks some builds).
@tautschnig tautschnig removed their assignment Mar 12, 2023
@kroening kroening merged commit fd457d2 into diffblue:develop Mar 22, 2023
@tautschnig tautschnig deleted the bugfixes/goto-ld branch March 22, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants