Skip to content

C front-end: fix whitespace in built-in declarations #7587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

tautschnig
Copy link
Collaborator

find_pattern uses '(' (note the parenthesis) to do string look-ups of declarations of built-ins. This failed for the ones addressed in this commit as the forward declaration had a whitespace before the opening parenthesis.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

find_pattern uses '<function-name>(' (note the parenthesis) to do string
look-ups of declarations of built-ins. This failed for the ones
addressed in this commit as the forward declaration had a whitespace
before the opening parenthesis.
@peterschrammel peterschrammel removed their assignment Mar 10, 2023
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ed48947) 78.50% compared to head (68ffb49) 78.50%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7587   +/-   ##
========================================
  Coverage    78.50%   78.50%           
========================================
  Files         1670     1670           
  Lines       191769   191769           
========================================
  Hits        150551   150551           
  Misses       41218    41218           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tautschnig tautschnig merged commit dd66867 into diffblue:develop Mar 10, 2023
@tautschnig tautschnig deleted the bugfixes/builtin-space branch March 10, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants