De-duplicate contracts regression tests #7581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should do the same thing in #7541. |
Reduce the maintenance burden by using tags to run contracts tests both
with and without DFCC. A first round of filtering was done as follows:
```
cd regression/contracts-dfcc ; sed -i '1s/$/ dfcc-only/' */*.desc
cd ../contracts
for d in * ; do
[ -d $d ] || continue
[ -d ../contracts-dfcc/$d ] || continue
cp -a ../contracts-dfcc/$d ../contracts-dfcc/X.$d
sed -i '1s/ dfcc-only$//' ../contracts-dfcc/X.$d/*.desc
sed -i '3s/--dfcc main //' ../contracts-dfcc/X.$d/*.desc
if diff -urN $d ../contracts-dfcc/X.$d ; then
sed -i '1s/ dfcc-only$//' ../contracts-dfcc/$d/*.desc
git rm -r $d
fi
rm -r ../contracts-dfcc/X.$d
done
```
Removal of duplicates based on a manual review of the diff between test directories of the same name.
tautschnig
force-pushed
the
cleanup/dedup-contracts-regression-tests
branch
from
7fb297a to
205e123
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #7581 +/- ##
===========================================
- Coverage 78.50% 78.41% -0.10%
===========================================
Files 1670 1670
Lines 191768 191768
===========================================
- Hits 150549 150373 -176
- Misses 41219 41395 +176
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tautschnig
added a commit
to tautschnig/cbmc
that referenced
this pull request
Mar 23, 2023
The tagged test configuration in diffblue#7581 introduced a race for multiple test runs would read/write via the same file names, and may be doing so concurrently. See https://github.com/diffblue/cbmc/actions/runs/4480043988/jobs/7874814034 for one such example.
3 tasks
jparsert
pushed a commit
to jparsert/cbmc
that referenced
this pull request
Apr 19, 2023
The tagged test configuration in diffblue#7581 introduced a race for multiple test runs would read/write via the same file names, and may be doing so concurrently. See https://github.com/diffblue/cbmc/actions/runs/4480043988/jobs/7874814034 for one such example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e22a788 added a wholesale copy of regression/contracts as regression/contracts-dfcc. This is now follow-up cleanup to reduce duplication with the intent to reduce future maintenance cost. See individual commit messages for details on how the cleanup was done.