Use GNU wget to download CVC5 on Windows 2022 CI job

[thomasspriggs]

The usage of Invoke-WebRequest to do the download of CVC5 has been unreliable on the Windows 2022 job. This commit is putting an alternative in place to see if this works as reliably on Windows as it has for the jobs on other platforms.

• Each commit message has a non-empty body, explaining why the change was made.
• Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
• The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
• Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
• My commit message includes data points confirming performance improvements (if claimed).
• My PR is restricted to a single feature or bugfix.
• White-space or formatting changes outside the feature-related changed lines are in commits of their own.

[tautschnig]

I have seen these problems repeatedly in recent times and I am wondering why the check-vs-2019-cmake-build-and-test job is not failing in the same way, even though it's using the same Invoke-Webrequest approach?

[thomasspriggs]

I have seen these problems repeatedly in recent times and I am wondering why the check-vs-2019-cmake-build-and-test job is not failing in the same way, even though it's using the same Invoke-Webrequest approach?

An interesting question indeed. I already took a look at the two jobs and I couldn't see any obvious differences in how the download was being done. So that means that there is either some difference in Invoke-Webrequest between Windows Server 2019 and Windows Server 2022 or there is a difference in the hosting environment for the two different platforms for github actions. Not knowing exactly what the cause of the difference is, is rather unsatisfying.

My reasoning for raising this PR was that it was better to try something different rather than leaving the unsatisfactory solution as is. An alternative approach would be to add extra arguments to Invoke-Webrequest to either instruct it to wait and retry or to tweak its credentials options. I settled on wget as it was working for the other platforms and it may make future maintenance marginally more straight forward if we are using the same tool across multiple jobs.

[codecov]

Codecov Report

Base: 78.41% // Head: 78.39% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (fd350d8) compared to base (206cf2a).
Patch has no changes to coverable lines.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #7531      +/-   ##
===========================================
- Coverage    78.41%   78.39%   -0.02%     
===========================================
  Files         1659     1663       +4     
  Lines       190382   191339     +957     
===========================================
+ Hits        149280   150005     +725     
- Misses       41102    41334     +232     

Impacted Files	Coverage Δ
src/util/validate_expressions.cpp	62.50% <0.00%> (-31.25%)	⬇️
src/big-int/bigint.cc	68.05% <0.00%> (-20.96%)	⬇️
src/util/string_container.cpp	37.03% <0.00%> (-14.82%)	⬇️
src/goto-programs/loop_ids.h	87.50% <0.00%> (-12.50%)	⬇️
src/util/validate_helpers.h	88.88% <0.00%> (-11.12%)	⬇️
src/util/string_utils.cpp	84.25% <0.00%> (-9.26%)	⬇️
src/util/string_container.h	90.90% <0.00%> (-9.10%)	⬇️
src/util/pointer_predicates.cpp	87.23% <0.00%> (-7.89%)	⬇️
src/solvers/smt2/smt2_dec.cpp	70.16% <0.00%> (-3.12%)	⬇️
src/pointer-analysis/value_set_fi.h	90.76% <0.00%> (-3.08%)	⬇️
... and 168 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[TGWDB]

On the basis that this may help things and this is a way to find out.