Skip to content

SMT back-end: fix type when RHS will be flattened #7252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

tautschnig
Copy link
Collaborator

When the right-hand side is a member expression the type has to be a bit vector (unless data types are used).

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

When the right-hand side is a member expression the type has to be a bit
vector (unless data types are used).
@tautschnig tautschnig marked this pull request as ready for review October 19, 2022 13:48
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Base: 78.00% // Head: 78.00% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (09cd9ac) compared to base (062bc0c).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7252   +/-   ##
========================================
  Coverage    78.00%   78.00%           
========================================
  Files         1621     1621           
  Lines       187279   187278    -1     
========================================
+ Hits        146088   146089    +1     
+ Misses       41191    41189    -2     
Impacted Files Coverage Δ
src/solvers/smt2/smt2_conv.cpp 65.39% <66.66%> (-0.01%) ⬇️
src/cprover/solver_progress.cpp 60.00% <0.00%> (-20.00%) ⬇️
src/cprover/solver.cpp 81.53% <0.00%> (-1.62%) ⬇️
src/cprover/propagate.cpp 73.52% <0.00%> (-1.48%) ⬇️
src/cprover/solver_types.h 88.88% <0.00%> (-0.59%) ⬇️
src/ansi-c/expr2c.cpp 67.27% <0.00%> (-0.05%) ⬇️
src/cprover/state_encoding.cpp 80.57% <0.00%> (+0.22%) ⬆️
src/cprover/axioms.cpp 92.11% <0.00%> (+0.54%) ⬆️
src/cprover/counterexample_found.cpp 93.33% <0.00%> (+11.19%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tautschnig tautschnig merged commit 7aaff0d into diffblue:develop Oct 21, 2022
@tautschnig tautschnig deleted the bugfixes/array-lhs branch October 21, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants