Skip to content

CHC solver: redesigned verbose output #7248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2022
Merged

CHC solver: redesigned verbose output #7248

merged 1 commit into from
Oct 19, 2022

Conversation

kroening
Copy link
Member

The solver's output when using --verbose is cleaned up (and now less verbose).

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The solver's output when using --verbose is cleaned up.
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 77.99% // Head: 78.00% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (5d2bf4e) compared to base (9d51ea2).
Patch coverage: 87.21% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #7248   +/-   ##
========================================
  Coverage    77.99%   78.00%           
========================================
  Files         1619     1621    +2     
  Lines       187194   187272   +78     
========================================
+ Hits        146007   146085   +78     
  Misses       41187    41187           
Impacted Files Coverage Δ
src/cprover/axioms.cpp 92.11% <ø> (+0.54%) ⬆️
src/cprover/console.cpp 29.06% <0.00%> (-2.19%) ⬇️
src/cprover/console.h 66.66% <ø> (ø)
src/cprover/counterexample_found.cpp 93.33% <ø> (+11.19%) ⬆️
src/cprover/state_encoding.cpp 80.57% <ø> (+0.22%) ⬆️
unit/util/expr_cast/expr_cast.cpp 100.00% <ø> (ø)
src/cprover/propagate.cpp 73.52% <44.44%> (-1.48%) ⬇️
src/cprover/solver.cpp 81.53% <48.00%> (-1.38%) ⬇️
src/cprover/solver_progress.cpp 60.00% <60.00%> (ø)
src/solvers/flattening/boolbv_byte_extract.cpp 69.73% <75.00%> (-0.40%) ⬇️
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use messaget::debug logging? A lot of code is now bound to wither away.

@kroening
Copy link
Member Author

Why not use messaget::debug logging? A lot of code is now bound to wither away.

Contemplating it -- the key issue was that the full output was really very difficult to read.

@kroening kroening merged commit 7e6f8ac into develop Oct 19, 2022
@kroening kroening deleted the chc_verbose branch October 19, 2022 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants