-
Notifications
You must be signed in to change notification settings - Fork 274
Dump-C: support struct/union types without tags #7162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
int main() | ||
{ | ||
calloc(10, 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite get why this creates a structure rather than an array?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment added.
CORE | ||
main.c | ||
--dump-c | ||
=(\(signed int \*\))?42 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why 42? I mean, in some ways, of course, 42! But...
Dump-C assumed that all occurrences of struct or union types would be via their tags. This was never a documented invariant, but largely true until 5ea97b3: that commit does introduce struct types in place, without making any effort to create tags. Dump-C now supports this case. Fixes: diffblue#7158
45c0f81
to
7d5801f
Compare
Codecov ReportBase: 77.89% // Head: 77.82% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7162 +/- ##
===========================================
- Coverage 77.89% 77.82% -0.08%
===========================================
Files 1576 1578 +2
Lines 181913 182242 +329
===========================================
+ Hits 141699 141824 +125
- Misses 40214 40418 +204
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Dump-C assumed that all occurrences of struct or union types would be via their tags. This was never a documented invariant, but largely true until 5ea97b3: that commit does introduce struct types in place, without making any effort to create tags. Dump-C now supports this case.
Fixes: #7158