Dump-C: support struct/union types without tags #7162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
martin-cs,
chris-ryder and
peterschrammel
as code owners
martin-cs
approved these changes
Sep 29, 2022
|
|
||
| int main() | ||
| { | ||
| calloc(10, 1); |
There was a problem hiding this comment.
I don't quite get why this creates a structure rather than an array?
| CORE | ||
| main.c | ||
| --dump-c | ||
| =(\(signed int \*\))?42 |
There was a problem hiding this comment.
Why 42? I mean, in some ways, of course, 42! But...
Dump-C assumed that all occurrences of struct or union types would be via their tags. This was never a documented invariant, but largely true until 5ea97b3: that commit does introduce struct types in place, without making any effort to create tags. Dump-C now supports this case. Fixes: diffblue#7158
tautschnig
force-pushed
the
bugfixes/7158-dump-c
branch
from
45c0f81 to
7d5801f
Compare
Codecov ReportBase: 77.89% // Head: 77.82% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7162 +/- ##
===========================================
- Coverage 77.89% 77.82% -0.08%
===========================================
Files 1576 1578 +2
Lines 181913 182242 +329
===========================================
+ Hits 141699 141824 +125
- Misses 40214 40418 +204
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dump-C assumed that all occurrences of struct or union types would be via their tags. This was never a documented invariant, but largely true until 5ea97b3: that commit does introduce struct types in place, without making any effort to create tags. Dump-C now supports this case.
Fixes: #7158