-
Notifications
You must be signed in to change notification settings - Fork 274
Log to file the SMT formula run by the solver #7161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log to file the SMT formula run by the solver #7161
Conversation
Codecov ReportBase: 78.36% // Head: 78.38% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7161 +/- ##
===========================================
+ Coverage 78.36% 78.38% +0.02%
===========================================
Files 1651 1651
Lines 190009 190058 +49
===========================================
+ Hits 148896 148973 +77
+ Misses 41113 41085 -28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dcb3aa7
to
2bdda65
Compare
2bdda65
to
2236012
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok with the changes so far, but you'll need to update the man page to make CI pass.
message_handlert &message_handler, | ||
const std::string &arg_name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Random place for comment: the commit message needs to be reviewed (spurious "---------------------", missing words after "that is being").
--dump-smt-formula logs the full SMT formula that is being passed to the solver to a file while also running the solver.
2236012
to
9b160e4
Compare
9b160e4
to
6174266
Compare
6174266
to
481c43e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not particularly satisfied with the code duplication this PR introduces between the smt_piped_solver_processt
class and the smt_incremental_dry_run_solvert
class. However I'd prefer to get this feature merged and worry about clean-up afterwards. I have a potential refactor to resolve this, which I will raise as a follow-up myself.
This PR introduces the new
--dump-smt-formula
argument that logs to a file the SMT formula given to the incremental SMT solver.This is different from the old
--outfile
argument as it does not run the solver, and, because of that, stops the generated file to the first(check-sat)
call.This PR requires the work to support
--outfile
that will be added by PR 7126, so it is dependant to its merge.