Skip to content

Add SMT quantifier data structures #7010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

thomasspriggs
Copy link
Contributor

This PR adds the forall and exists SMT quantifier data structures, along with their conversion to string and unit tests.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The conversion to string is unimplemented in this commit be will be
added as a later commit in this PR.
The conversion to string is unimplemented in this commit be will be
added as a later commit in this PR.
@thomasspriggs thomasspriggs marked this pull request as ready for review July 13, 2022 15:30
@thomasspriggs thomasspriggs requested a review from esteffin July 13, 2022 15:30
@codecov
Copy link

codecov bot commented Jul 13, 2022

Codecov Report

Merging #7010 (4a0b099) into develop (4d5d529) will increase coverage by 0.01%.
The diff coverage is 96.57%.

@@             Coverage Diff             @@
##           develop    #7010      +/-   ##
===========================================
+ Coverage    77.85%   77.87%   +0.01%     
===========================================
  Files         1569     1569              
  Lines       180656   180817     +161     
===========================================
+ Hits        140648   140805     +157     
- Misses       40008    40012       +4     
Impacted Files Coverage Δ
...smt2_incremental/construct_value_expr_from_smt.cpp 100.00% <ø> (ø)
unit/solvers/smt2_incremental/smt_terms.cpp 93.23% <92.15%> (-0.67%) ⬇️
...rc/solvers/smt2_incremental/smt_to_smt2_string.cpp 95.65% <95.65%> (+1.24%) ⬆️
...smt2_incremental/construct_value_expr_from_smt.cpp 100.00% <100.00%> (ø)
src/solvers/smt2_incremental/smt_terms.cpp 97.05% <100.00%> (+1.34%) ⬆️
src/solvers/smt2_incremental/smt_terms.def 100.00% <100.00%> (ø)
src/solvers/smt2_incremental/smt_terms.h 100.00% <100.00%> (ø)
...it/solvers/smt2_incremental/smt_to_smt2_string.cpp 100.00% <100.00%> (ø)
src/goto-cc/gcc_cmdline.cpp 79.23% <0.00%> (ø)
src/goto-cc/armcc_cmdline.cpp 22.22% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22fec4c...4a0b099. Read the comment docs.

Copy link
Contributor

@esteffin esteffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@thomasspriggs thomasspriggs merged commit f9bd83e into diffblue:develop Jul 14, 2022
@thomasspriggs thomasspriggs deleted the tas/smt_quantifier_data_structures branch July 14, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants