Skip to content

SMT2 backend: generate simple symbols #6940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 21, 2022
Merged

Conversation

kroening
Copy link
Member

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

kroening added 2 commits June 16, 2022 18:32
The quotes |...| are now added in one place by convert_identifier, instead
of asking all consumers of identifiers to do this.
The |...| for quoting are unneccesary when the symbol name meets the
definition of a simple symbol.
@codecov
Copy link

codecov bot commented Jun 17, 2022

Codecov Report

Merging #6940 (baba52b) into develop (40bd2b5) will increase coverage by 0.00%.
The diff coverage is 96.87%.

@@           Coverage Diff            @@
##           develop    #6940   +/-   ##
========================================
  Coverage    77.79%   77.79%           
========================================
  Files         1568     1568           
  Lines       180329   180347   +18     
========================================
+ Hits        140290   140309   +19     
+ Misses       40039    40038    -1     
Impacted Files Coverage Δ
src/solvers/smt2/smt2_tokenizer.h 96.96% <ø> (ø)
src/solvers/smt2/smt2_dec.cpp 73.27% <90.00%> (+2.10%) ⬆️
src/solvers/smt2/smt2_conv.cpp 67.90% <97.29%> (+0.13%) ⬆️
src/solvers/smt2/smt2_tokenizer.cpp 97.70% <100.00%> (ø)
...rc/solvers/smt2_incremental/smt_to_smt2_string.cpp 94.30% <100.00%> (ø)
unit/solvers/smt2/smt2_conv.cpp 100.00% <100.00%> (ø)
...it/solvers/smt2_incremental/smt_to_smt2_string.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0deef16...baba52b. Read the comment docs.

@kroening kroening marked this pull request as ready for review June 17, 2022 12:59
@tautschnig tautschnig merged commit 3a6341f into develop Jun 21, 2022
@tautschnig tautschnig deleted the smt2-simple-symbol branch June 21, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants